Commit Graph

3780 Commits (7b4ef4647ada77d9e5dde9f336f40b266cbfeefb)

Author SHA1 Message Date
Scott Addie 7b4ef4647a
Update button text in web API 2.1 app (#9615)
Related to https://github.com/aspnet/Docs/pull/9602. Applies the same change to the 2.1 sample app.
2018-11-16 10:23:51 -06:00
Scott Addie 61040c22bd
Restore tip in SignalR tutorial (#9614)
Restore a tip that was inadvertently removed.
2018-11-16 10:18:21 -06:00
Alistair McMillan f598f928e2 Update title of button in HTML code for clarity (#9602)
Minor change but it seems a little confusing to call the button "Edit" when you use it to "Save" or "Submit" your changed todo item.
2018-11-16 10:14:06 -06:00
Luke Latham 62b29253b2
Clarify env vars in Web Host building remarks (#9599) 2018-11-15 14:15:37 -06:00
Scott Addie efa3c4e0c2
Link to Requirements creation section (#9600)
Fixes https://github.com/aspnet/Docs/issues/9584

Also replaced the tabs with moniker ranges while I was in there.
2018-11-15 13:44:05 -06:00
Luke Latham 8031f63a22 Surface Forward Headers in ext auth provider topics (#9554)
Fixes #9549 

* Not a full UE pass on the group of external provider topics ... don't quite have time for that right now. However, I do hit a number of small UE-type updates.
* Engineering: You only need to look at one thing here: See the *forwarded-headers-middleware.md* file. The content of the file is below. The INCLUDE is linked into the external auth provider topics to surface Forwarded Headers Middleware (proxy/LB topic).

> \#\# Forward request information with a proxy or load balancer
>
> If the app is deployed behind a proxy server or load balancer, some of the original request information might be forwarded to the app in request headers. This information usually includes the secure request scheme (\`https\`), host, and client IP address. Apps don't automatically read these request headers to discover and use the original request information.
>
> The scheme is used in link generation that affects the authentication flow with external providers. Losing the secure scheme (\`https\`) results in the app generating incorrect insecure redirect URLs.
>
> Use Forwarded Headers Middleware to make the original request information available to the app for request processing.
>
> For more information, see \<xref:host-and-deploy/proxy-load-balancer>.

If it's easier to provide feedback in a comment here over hunting down the file on the diff, that works for me.
2018-11-14 15:58:01 -06:00
Luke Latham bb8267cc27 IHostedService StopAsync cancellationToken updates (#9555)
Fixes #9144 

[Internal Review Topic](https://review.docs.microsoft.com/en-us/aspnet/core/fundamentals/host/hosted-services?view=aspnetcore-2.1&branch=pr-en-us-9555#ihostedservice-interface)

cc: @ygoe
2018-11-14 15:43:07 -06:00
Andrew Stanton-Nurse 5fb2514a42 fix aspnet/SignalR#3190 by adding docs on cancellation in 2.2 (#9346)
fixes aspnet/SignalR#3190

ASP.NET Core SignalR now has support for a CancellationToken in Hub methods. This updates our docs to show that support in the ASP.NET Core 2.2 version of the docs

My first time using `:::moniker range`, and I think it's appropriate here. We'll see if I did it right :)

| Review Links | 2.1 | 2.2 |
| ------------ | --- | --- |
| ~~Hubs API~~ | ~~[Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/hubs?view=aspnetcore-2.1&branch=pr-en-us-9346)~~ | ~~[Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/hubs?view=aspnetcore-2.2&branch=pr-en-us-9346)~~ |
| Streaming | [Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/streaming?view=aspnetcore-2.1&branch=pr-en-us-9346) | [Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/streaming?view=aspnetcore-2.2&branch=pr-en-us-9346) |
2018-11-14 14:44:06 -06:00
Brady Gaster 5bc17d6b99 Removed PersistentConnection from ASP.NET Core SignalR (#9466)
* fixes #9358

* thanks!

Co-Authored-By: bradygaster <41929050+bradygaster@users.noreply.github.com>

* changed verbiage per @tdykstra

* Edit pass
2018-11-14 10:48:45 -06:00
Brady Gaster a9e109763f adding javascript reconnect docs (#9345)
adding some work to address #6757, though this PR fails to contribute a holistic document addressing the entire topic of reconnections.
2018-11-14 10:44:47 -06:00
Ahmed Yahia 7e53e1a380 Update hubcontext.md (#9547) 2018-11-14 10:25:28 -06:00
Robb Schiefer 0d1834264f Added note for working with virtual directories (#9128)
I spent a day or more researching this so that I could use Swagger-UI in my ASP.NET Core API which is used with a reverse-proxy and virtual directory.  In the end found Swagger-UI requires relative URLs to start with a period.  Related to https://github.com/swagger-api/swagger-ui/issues/4107

Hoping this documentation note will help others.

When creating a new PR, please do the following and delete this template text:

* Reference the issue number if there is one:

  Fixes #Issue_Number

  > The "Fixes #nnn" syntax in the PR description causes
  > GitHub to automatically close the issue when this PR is merged.
2018-11-14 10:11:23 -06:00
Rick Anderson 73fda161c8 Update index.md (#9581)
Give it more SEO juice for those searching.
2018-11-14 09:53:48 -06:00
Pranav K 78b9850bf1 Add docs for api conventions and analyzers (#9453)
* Add docs for api conventions and analyzers
Fixes #8332

* Edit pass on API conventions and analyzers content (#9574)

* Edit pass on 2.2 API docs (#9578)

* Scottaddie/open api patch (#9582)

* Edit pass on 2.2 API docs

* Resolve build warning

* Fix list formatting
2018-11-13 21:39:41 -06:00
Luke Latham 5cfc4cdda0
Clarify shared DP version for shared DP payloads (#9546) 2018-11-13 13:43:40 -06:00
Scott Addie e20f03cce1
Replace BinderModelName with ModelName (#9562)
Fixes https://github.com/aspnet/Docs/issues/9476

[Internal Review Page](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/advanced/custom-model-binding?view=aspnetcore-2.1&branch=pr-en-us-9562#custom-model-binder-sample)
2018-11-13 11:23:39 -06:00
Daniel Morrison a500aaf087 Fixes #9557 The sample code for the ASP.NET Core SignalR does not work due to a path issue. (#9564)
This addresses the issue #9557 that I was working on with @scottaddie.

Unfortunately, I experienced severe GitHub workflow issues, and the pull request was closed.
2018-11-13 09:47:53 -06:00
Steve Gordon 8b84b42a5f Fixing the wording of a sentence (#9569) 2018-11-13 08:34:37 -06:00
Luke Latham 7bb699bf1b Version the 1.1 PDF of the Kestrel and Web Host topics (#9567)
Fixes #9565
2018-11-12 16:44:39 -10:00
Andrew Stanton-Nurse 0dfa5e0723 updates to hubs document (#9501)
fixes #9497 as well

Some updates that came up as I was writing #9455 but didn't fit there.

[Internal Review Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/hubs?view=aspnetcore-2.1&branch=pr-en-us-9501)
2018-11-12 15:53:53 -06:00
Vincent Pestana cb089c7f1d Update Login.cshtml.cs (#9560) 2018-11-12 15:21:01 -06:00
Andrew Stanton-Nurse f4e90f4af7 fix #9405 by adding api design docs (#9455)
fixes #9405

add some API design docs. I decided some of the things in #9405 (HubMethodName, Typed clients, etc.) fit better in the Hub API doc so I'll submit a separate PR for those soon

I'm sure I messed up the code snippets somehow :). Will have to wait and see how the review copy turns out.

[Internal Review Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/api-design?view=aspnetcore-2.1&branch=pr-en-us-9455)
2018-11-12 15:16:31 -06:00
Luke Latham 84b7eb8c91 React to InheritInChildApplications in IIS/ANCM (#9545)
Fixes #9503 

[Internal Review Topic (IIS index; Sub-application configuration section)](https://review.docs.microsoft.com/en-us/aspnet/core/host-and-deploy/iis/index?view=aspnetcore-1.0&branch=pr-en-us-9545#sub-application-configuration)
[Internal Review Topic (ANCM; Configuration with web.config section)](https://review.docs.microsoft.com/en-us/aspnet/core/host-and-deploy/aspnet-core-module?view=aspnetcore-1.0&branch=pr-en-us-9545#configuration-with-webconfig)

btw - Should I ping one of you first, then it would be handed off to the other in the event the first is busy? If so, who should get the review request first?
2018-11-12 14:25:27 -06:00
Tom Dykstra 8de0f67c2b
Don't escape # except at start of a line (#9559) 2018-11-12 09:36:41 -08:00
Ahmed Yahia 99747947f9 Fix constructor name in sample code (#9548) 2018-11-12 07:43:20 -08:00
Luke Latham 85b1f1ca05 Touch-ups to preprocessor symbols content (#9551)
Addresses #9470 
Addresses #9544 

We trust the build system for so much. 🤔 ... Shouldn't I *really* just nix the backslashes?
2018-11-10 14:38:19 -10:00
Ahmed Yahia cea6c0b17e "call to connection" --> "call on connection" in hubs.md (#9542) 2018-11-10 14:07:37 -08:00
Luke Latham 82d62266c0 Update 'checkbox' (#9419)
Fixes #9418 

Cleaning today and found a note *under my keyboard* to knock these out. 😀
2018-11-10 09:13:52 -10:00
Luke Latham af27696750 Update 'Static Files Middleware' (#9421)
Fixes #9420

The correct name includes "File" (singular).

Ref: https://docs.microsoft.com/dotnet/api/microsoft.aspnetcore.staticfiles.staticfilemiddleware
2018-11-10 09:13:27 -10:00
Luke Latham 6f3bdb8a4c Clarify use of preprocessor directives with samps (#9544)
Fixes #9470 

[Internal Review Topic (How to download a sample section)](https://review.docs.microsoft.com/en-us/aspnet/core/index?view=aspnetcore-1.0&branch=pr-en-us-9544#how-to-download-a-sample)

I'm not very trusting of  *Magic Build Systems* . I usually encode reserved DocFX characters outside of code-fenced content ... *they'll **never** break this way no matter what the build system thinks about them*.

If you prefer that I go with either a backslash (safe) or roll the 🎲🎲 and use unencoded chars with build system processing trust, let me know which alternate way you would like to go. Again, my approach is **_bulletproof_**.

Thanks @rswetnam! 🚀
2018-11-10 09:04:16 -10:00
Luke Latham ae2fe91c1a Link topic sample into the RP file uploads topic (#9543)
Fixes #9482 

Thanks @jhealy! 🚀
2018-11-10 09:01:18 -10:00
Rick Anderson 1b2730ca76
Update rp-over-mvc-21.md (#9535) 2018-11-09 11:29:45 -10:00
Rick Anderson 08fff61fef
RP vs MVC tutorial (#9486)
* RP vs MVC tutorial

* Update razor.md

* Update razor.md

* Update razor.md
2018-11-09 09:13:58 -10:00
Daniel Abbatt 4fa8d9f652 Docs: Mentioned that the Controller name replacement is by convention (#9493)
Making it a bit clearer that the [controller] name replacement of MyNameController is by naming convention.



<!--
When creating a new PR, please do the following:

* Reference the issue number if there is one, e.g.:

Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description allows GitHub to automatically close the issue when this PR is merged.

NOTE: This is a comment; please type your descriptions above or below it.
-->
2018-11-09 09:11:40 -10:00
Hao Kung 3addeffb39 Update options for 2.2 (#9456) 2018-11-09 13:01:33 -06:00
Luke Latham 386d64b59d
Generic Host topic updates (#9341) 2018-11-08 20:10:30 -06:00
Rick Anderson 90a9ac31f5
localize decimal (#9528)
Fixes #9414
2018-11-08 15:50:19 -10:00
John Luo 78ec46c2e7
Clarification for HTTP/2 support with Kestrel on Windows8.1/Server2012R2 (#9522) 2018-11-08 14:25:47 -08:00
Ahmed Yahia 3a509ad664 Update options.md (#9517) 2018-11-08 16:08:14 -06:00
Rick Anderson 577b6b8898
Update mvc.md (#9521) 2018-11-08 11:58:57 -10:00
BrennanConroy 7ad8de6966 Update SignalR differences (#9457) 2018-11-08 08:46:32 -08:00
Stephen Halter 4307e3131d
Discuss absence of HTTP/2 request rate limit features (#9511)
<!--
When creating a new PR, please do the following:

* Reference the issue number if there is one, e.g.:

Fixes #Issue_Number

The "Fixes #nnn" syntax in the PR description allows GitHub to automatically close the issue when this PR is merged.

NOTE: This is a comment; please type your descriptions above or below it.
-->
2018-11-07 18:21:30 -08:00
Kevinio04 3ce1f44830 Exclude Bin and Obj when copying to output directory (#9507) 2018-11-07 19:23:23 -06:00
Kevinio04 fbf918a74e Exclude Bin and Obj from CopyToOutputDirectory (#9508) 2018-11-07 19:12:50 -06:00
Tom Dykstra eb67d3a497
http --> https in sample URLs in SignalR security.md (#9500) 2018-11-07 09:27:17 -08:00
Andrew Stanton-Nurse f8acc64223 Expand upon SignalR access token logging section (#9440)
From #9424 discussions

Expanded a bit on how access token logging affects your app and what it means. Also, how to disable URL logging entirely in ASP.NET Core (this is a bit of a severe option, since it disables logging of ALL request URLs).

cc @Tratcher

[Internal Review Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/security?view=aspnetcore-2.1&branch=pr-en-us-9440)
2018-11-07 09:23:41 -06:00
Justin Kotalik a6b77c370c Update IIS index.md (#9463)
More for #9441 with a bit of refactoring.

- IISServerOptions (inproc) are unique from IISOptions (out of proc)
- Move HTTP/2 topic lower in the document (flow felt off by having it before how to enable IISIntegration)
- Remove stop/starting app pool in favor of dropping app_offline (@shirhatti for thoughts)
- Generalize addressing AspNetCore behind IIS (remove reverse proxy stuff).
2018-11-06 22:18:14 -06:00
Rick Anderson 346721a118
Update page1.md (#9491)
* Update page1.md

* Update page1.md
2018-11-06 17:22:30 -10:00
Mikael Mengistu 8439a641fe SignalR Java Client Access token provider section (#9454)
Fixes https://github.com/aspnet/Docs/issues/9171
Adding a short section in the Java client docs about setting up an Access Token provider.
2018-11-06 16:24:43 -06:00
BrennanConroy d396dffe19 WebSocket Origin Restriction (#9447)
Fixes https://github.com/aspnet/Docs/issues/9363

[Internal Review Link](https://review.docs.microsoft.com/en-us/aspnet/core/signalr/security?view=aspnetcore-2.2&branch=pr-en-us-9447)
There are some moniker ranges, so switch the versions to verify they're working
2018-11-06 15:55:48 -06:00