Fixes#11232
This heading ...
> \#\# Moving from WebHostBuilder to HostBuilder
... didn't seem to make sense because the prior section is addressing the same migration aspect. These two sections were probably added at different times (guessing), which would explain the (accidental) appearance of both.
I see a handful of little super-nits in the view comp file beyond the few that I touch here (mostly punctuation on this PR), but I'll leave those unless you want me to edit the file.
* Fixes#10944
* Update of controller DI rewrite
* work
* work
* work
* work
* work
* work
* work
* Update aspnetcore/mvc/controllers/dependency-injection.md
Co-Authored-By: Rick-Anderson <riande@microsoft.com>
* Apply suggestions from code review
Co-Authored-By: Rick-Anderson <riande@microsoft.com>
Fixes#10906
@tdykstra see @guardrex original [here](ce55bac02e). I'm starting to think his original might be better.
It's an alway run filter, shouldn't we get that point across. My version if far too verbose but has the thoughts I want to conveigh.
Fix https://github.com/aspnet/Docs/issues/10636
### Question
@Rick-Anderson
Under 7f52e7646a/aspnetcore/mvc/views/view-components.md (specifying-a-view-name)
I don't know why there is the sentance`Update Views/ToDoList/Index.cshtml:` Maybe we must say instead `Update Views/ToDo/Index.cshtml:`
Furthermore, there is a comment ` <!-- Views/ToDoList/Index.cshtml is never imported, so change to test tutorial -->` . But the Views/TodoList doesn't exist ? Should we delete this comment?
Sorry, I don't understand well…
* Update About.cshtml
The WebsiteContext instance was initialized inside a C# code block to avoid a possible problem when one of its attributes is a string.
* Update authoring.md
Update highlights and ranges after updating the relevant source code:
authoring/sample/AuthoringTagHelpers/src/AuthoringTagHelpers/Views/Home/About.cshtml
Fixes#10264
[Review URL](https://review.docs.microsoft.com/en-us/aspnet/core/mvc/models/validation?view=aspnetcore-2.2&branch=pr-en-us-10390)
* Not too keen on "top-level node." It isn't documented anywhere, and Google Fu wasn't much help either. I've *guessed* from the API what it means (and I could be *wrong*).
* Side note: `Required` is *required* as a model property attribute to get client-side required validation to work AFAICT. Adding `Required` or `BindRequired` to the top-level node (parameter) doesn't make it work client-side. Not sure if that's an issue or not ... just a side behavior that I noticed when testing.
* `jQuery.validate()` doesn't seem to be a thing any longer. JS complains that it can't find the function with the most recent jQuery validation scripts (from the current templates). Everything seems to work without it, so I nixed it.
* The sample was *almost* updated for 2.2. This should take it across the finish line. 🏁
* In the OP, the dev said that they were missing `AddDataAnnotations`, but we don't doc that level of detail. If they go `AddMvcCore`, they're kind'a on their own to make sure that they have all of the bits in place.
* Add example of asp-area with a Razor Pages area
* Minor edits
* Fix code snippet include
* Add example of AllowAreas property
* Update aspnetcore/mvc/views/tag-helpers/built-in/anchor-tag-helper.md
Co-Authored-By: scottaddie <10702007+scottaddie@users.noreply.github.com>
Fixes#9336
<!--
When creating a new PR, please do the following:
* Reference the issue number if there is one, e.g.:
Fixes #Issue_Number
The "Fixes #nnn" syntax in the PR description allows GitHub to automatically close the issue when this PR is merged.
NOTE: This is a comment; please type your descriptions above or below it.
-->
Fixes#6971
<!--
When creating a new PR, please do the following:
* Reference the issue number if there is one, e.g.:
Fixes #Issue_Number
The "Fixes #nnn" syntax in the PR description allows GitHub to automatically close the issue when this PR is merged.
NOTE: This is a comment; please type your descriptions above or below it.
-->
* overview
* whats new to end
* fix migration node
* split fundamentals, move to end
* glob & loc, get started
* security node name
* security section
* azure, client-side, host
* several more sections
* redistribute tutorials
* proofread fixes
* move how to download section
* index files delete and redirect
* fix errors
* reorder some nodes
* scott feedback, flatten main tutorials node
* fix missed feedback items + other issues
* unflatten tutorials node
* move 'how to download'
* more tutorials node tweaks
* standardize view sample links
* db --> DB
* fix build error
* remove link from a parent node
* streamline node names
* xref links
* typos
* typo
* typos and revert some xref links
* scott feedback
* scott feedback
* feedback
* change node name
* safe storage-->protect
Fixes#9219
@JunTaoLuo Dan calls out the implicit versioning "for 2.1 SDK or later;" however, we don't usually version the doc content by SDK release. We might need to say something for this update in the passage that I'm adding to the All topic (*aspnetcore/fundamentals/metapackage.md*) about which SDK version this applies to. I don't know if that's something that you would like to do or what version to call out.
I also remove the version from the samples. We also assume that devs are using the latest SDK with our samples.
I will not lie: this was not enjoyable. With the realization that this page might be shuffled around to a new spot in the TOC, it was a delicate act balancing Razor pages and traditional MVC without getting too intrusive about it.
As such, I:
* Included a note at the top of the document outlining the subtle differences, so I can just casually reference them later and don't have to explain which is which
* Replaced wording of "views" with "pages or views"
* Changed controller wording to "the folder where the handler method (or controller) exists."
I also updated the *_Layout.cshtml* sample file. It's a little different, two years later.
I expect some back-and-forth about this—let me know what you think, @Rick-Anderson.
Fixes#8030
Hello, @rick-anderson,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: Some of the "folder names" inside \<\> are not displaying well in localized pages, and also those terms are not blocked for localization.
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Addresses #8579
I might be getting the hang of **_find and replace_** now. 😝
This doesn't touch a couple that ref 2.2.0. I'll tidy those up on https://github.com/aspnet/Docs/issues/8518 after 2.2 RTM.
Add separate section using h3 title to separate out the IFilterFactory description from that of the TypeFilterAttribute when discussing dependency injection.
Hello, @ardalis,
This proposed file change comes from https://github.com/aspnet/Docs.pt-br/pull/81 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.
When creating a new PR, please do the following and delete this template text:
* Reference the issue number if there is one:
Fixes #Issue_Number
> The "Fixes #nnn" syntax in the PR description causes
> GitHub to automatically close the issue when this PR is merged.
Related to https://github.com/aspnet/Docs/pull/4599.
Removed unnecessary `@` symbols, added missing double quotes, and replaced inline code snippet with code import.
Hello, @rick-anderson ,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
"The unescaped '@' sign is breaking the code"
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR.
Many thanks in advance.
Hello, @rick-anderson ,
This proposed file change comes from https://github.com/aspnet/Docs.zh-tw/pull/56.
Could you review this contribution and help to merge if agreed?
Many thanks in advance.
I just tested and it does not matter whether the project in vs2017 is created with or without authentication regarding the _viewimports file. Seems odd it mentions that making the reader think that there is a difference or why would it be mentioned. Second ,and not sure if this should be addressed because it might be the tip of the iceberg, the files are no longer in views/ but are now in pages/
Nick Schonning
Scott Addie
MSDev_NilTor
Rick Anderson
Luke Latham
N. Taylor Mullen
Pranav K
Tawfik Khalifeh
Cédric Luthi
lindexi
Nikita Potapenko
Tom Dykstra
Mark Francis
Shadi Namrouti
Julio
Patrick Westerhoff
Jacob Stamm
Henrik Røn
Martin Zikmund
Dave Brock
stefanhamburger
buddhacatmonk
Martin Koudelka
Steve Gordon
Jakub Gutkowski
Abbas M
SONG WONSEOK
Charmis Varghese
Mark Iannucci
Scott Addie
Mauricio de los Santos
James Newton-King
Andrew Lock
Roy
Eduardo Cogo da Rocha
Eric Stimpson
Brian Behm
John Osborne
Peter Kellner
Brandon
Cristian Civera
Babu Annamalai
Daniel J. Summers