History lessons should be in a history doc, not in the primary doc. You can move this to a topic that compares classic SignalR to Core. I'm sure the list is extensive.
* 8.0 update SignalR config: withServerTimeout
* Clarified Keep-Alive interval is withKeepAliveInterval.
* Added details to withKeepAliveIntervalInMilliseconds for JavaScript.
* Improved order of info on withKeepAliveInterval
* Apply suggestions from code review
Commit review changes made by tdykstra
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
* Changes per review feedback, BrennanConroy and Tdykstra.
* Replaced hubconnection object with HubConnectionBuilder per feedback BrennanConroy
* Corrected HandshakeTimeout to created on HubConnection object per review feedback
---------
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
* SignalR: Reference shared framework
* Update aspnetcore/signalr/hubs.md
Committing the inline suggestion, and then will update the missing link afterwards.
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
* Moved 7.0 version up, moved new note to bottom of topics
* Removed dupe.
* added note in 5 more topics, moved latest versions to top where needed
* New include, reduced number of topics, added resources links
* Moved link in migration doc to internal.
* Added description for xref since subsection title not generated
* Removed note from hubcontext, using additional resources link now
* Reduced new section in migration topic per Rick suggestion
* Apply suggestions from code review
Added additional suggestions to link.
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
* Moved note back to near top of hubs.md all 3 versions per Brennan suggestion
---------
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
* SignalR clarify connectionID access options
* Draft: Corrected instruction and links.
* Added mention of in-memory storage option
* Clarified on storage options such as in-memory or permanent
* Moved storage options under singleton service.
* Update aspnetcore/signalr/hubcontext.md
Adding Rick's suggestion.
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
---------
Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
* Update hubs.md
Make it clear that Hubs should not be created directly.
* Updates
* Update hubs.md
Improved wording.
---------
Co-authored-by: Luke Latham <1622880+guardrex@users.noreply.github.com>
* No need to explicitly call RemoveFromGroupAsync
The sample added this explicit `RemoveFromGroupAsync` call when the connection disconnects, however, it is a redundant call since when the connection disconnects, it is automatically removed from the group.
We have customers using Azure SignalR followed this sample and invokes `RemoveFromGroupAsync` for every client disconnect, this increases unnecessary burdon to the Azure SignalR service when the client connection closes burst.
* Update hubs.md
Section Handle events for a connection for all versions: Noted no need for RemoveFromGroupAsync in OnConnectedAsync
* Update hubs.md
Added note on RemoveFromGroupsAsync to all versions of topic. Corrected Typo.
* Update aspnetcore/signalr/hubs.md
Improved statement.
Co-authored-by: Brennan <brecon@microsoft.com>
* Update hubs.md
Updated statement on RemoveFromGroupAsync for all topic versions.
* Update gRPC example for StronglyTypedChatHubs.cs
Removed RemoveFromGroupAsync call from OnDisconnectedAsync.
Co-authored-by: Wade Pickett <wpickett@microsoft.com>
Co-authored-by: Brennan <brecon@microsoft.com>
* .NET 6 update for SignalR auth and authz /1
* .NET 6 update for SignalR auth and authz /1
* .NET 6 update for SignalR auth and authz /1
* .NET 6 update for SignalR auth and authz /1
* .NET 6 update for SignalR auth and authz /1
* .NET 6 update for SignalR auth and authz /1
* react to feedback
* minor updates
Rick Anderson
Luke Latham
Wade Pickett
Brennan
Ville Kylmämaa
Neutrino
Stephen Halter
JialinXin
Alex Buck
Liangying.Wei
sammychinedu2ky
Kirk Larkin
Dave Pringle
pitulescubogdan