mirror of https://github.com/nodejs/node.git
tools: remove obsolete no-restricted-syntax eslint rules
These rules only apply for the test folder and will already be checked for. PR-URL: https://github.com/nodejs/node/pull/32161 Refs: https://github.com/nodejs/node/pull/32078 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>pull/33316/head
parent
36b2e25b4a
commit
18584727de
44
.eslintrc.js
44
.eslintrc.js
|
@ -189,34 +189,6 @@ module.exports = {
|
|||
// as well to lib/.eslintrc.yaml.
|
||||
'no-restricted-syntax': [
|
||||
'error',
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
|
||||
message: 'Do not use a literal for the third argument of assert.deepStrictEqual()',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='doesNotThrow']",
|
||||
message: 'Do not use `assert.doesNotThrow()`. Write the code without the wrapper and add a comment instead.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='doesNotReject']",
|
||||
message: 'Do not use `assert.doesNotReject()`. Write the code without the wrapper and add a comment instead.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='rejects'][arguments.length<2]",
|
||||
message: '`assert.rejects()` must be invoked with at least two arguments.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='strictEqual'][arguments.2.type='Literal']",
|
||||
message: 'Do not use a literal for the third argument of assert.strictEqual()',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
|
||||
message: 'Use an object as second argument of `assert.throws()`.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='throws'][arguments.length<2]",
|
||||
message: '`assert.throws()` must be invoked with at least two arguments.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
|
||||
message: '`setTimeout()` must be invoked with at least two arguments.',
|
||||
|
@ -229,22 +201,6 @@ module.exports = {
|
|||
selector: 'ThrowStatement > CallExpression[callee.name=/Error$/]',
|
||||
message: 'Use `new` keyword when throwing an `Error`.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='notDeepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
|
||||
message: 'The first argument should be the `actual`, not the `expected` value.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='notStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
|
||||
message: 'The first argument should be the `actual`, not the `expected` value.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='deepStrictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
|
||||
message: 'The first argument should be the `actual`, not the `expected` value.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
|
||||
message: 'The first argument should be the `actual`, not the `expected` value.',
|
||||
},
|
||||
{
|
||||
selector: "CallExpression[callee.name='isNaN']",
|
||||
message: 'Use Number.isNaN() instead of the global isNaN() function.',
|
||||
|
|
Loading…
Reference in New Issue