From 1acc14baf9ca1cc52f001fbe0453c2a540571c21 Mon Sep 17 00:00:00 2001
From: Ruben Bridgewater <ruben@bridgewater.de>
Date: Fri, 8 May 2020 02:39:59 +0200
Subject: [PATCH] repl: add builtinModules
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This adds an alias to `_builtinLibs` that is documented and should
as such also be accessed publicly. It does not contain any
underscored modules.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: https://github.com/nodejs/node/pull/33295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
---
 doc/api/repl.md                         |  9 +++++++++
 lib/repl.js                             |  9 ++++++++-
 test/parallel/test-repl-tab-complete.js | 13 +++++++++++--
 3 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/doc/api/repl.md b/doc/api/repl.md
index d52ff0e7d01..5a2c35f4a1c 100644
--- a/doc/api/repl.md
+++ b/doc/api/repl.md
@@ -540,6 +540,15 @@ by default. However, this is not the case when creating a REPL
 programmatically. Use this method to initialize a history log file when working
 with REPL instances programmatically.
 
+## `repl.builtinModules`
+<!-- YAML
+added: REPLACEME
+-->
+
+* {string[]}
+
+A list of the names of all Node.js modules, e.g., `'http'`.
+
 ## `repl.start([options])`
 <!-- YAML
 added: v0.1.91
diff --git a/lib/repl.js b/lib/repl.js
index 45061119dbc..d5e41d41b64 100644
--- a/lib/repl.js
+++ b/lib/repl.js
@@ -86,7 +86,7 @@ const {
 const { Console } = require('console');
 const CJSModule = require('internal/modules/cjs/loader').Module;
 let _builtinLibs = [...CJSModule.builtinModules]
-  .filter((e) => !e.startsWith('_'));
+  .filter((e) => !e.startsWith('_') && !e.includes('/'));
 const domain = require('domain');
 const debug = require('internal/util/debuglog').debuglog('repl');
 const {
@@ -1559,6 +1559,13 @@ module.exports = {
   Recoverable
 };
 
+ObjectDefineProperty(module.exports, 'builtinModules', {
+  get: () => _builtinLibs,
+  set: (val) => _builtinLibs = val,
+  enumerable: true,
+  configurable: true
+});
+
 ObjectDefineProperty(module.exports, '_builtinLibs', {
   get: pendingDeprecation ? deprecate(
     () => _builtinLibs,
diff --git a/test/parallel/test-repl-tab-complete.js b/test/parallel/test-repl-tab-complete.js
index 0511e32d0a9..564867af5b3 100644
--- a/test/parallel/test-repl-tab-complete.js
+++ b/test/parallel/test-repl-tab-complete.js
@@ -237,9 +237,18 @@ putIn.run(['.clear']);
 testMe.complete('require(\'', common.mustCall(function(error, data) {
   assert.strictEqual(error, null);
   builtinModules.forEach((lib) => {
-    if (!lib.startsWith('_'))
-      assert(data[0].includes(lib), `${lib} not found`);
+    assert(
+      data[0].includes(lib) || lib.startsWith('_') || lib.includes('/'),
+      `${lib} not found`
+    );
   });
+  const newModule = 'foobar';
+  assert(!builtinModules.includes(newModule));
+  repl.builtinModules.push(newModule);
+  testMe.complete('require(\'', common.mustCall((_, [modules]) => {
+    assert.strictEqual(data[0].length + 1, modules.length);
+    assert(modules.includes(newModule));
+  }));
 }));
 
 testMe.complete("require\t( 'n", common.mustCall(function(error, data) {