From 1d49558273adec600a947596b7dbff236953c3d2 Mon Sep 17 00:00:00 2001 From: Sam Roberts Date: Thu, 19 Mar 2020 09:09:23 -0700 Subject: [PATCH] Revert "build: add asan check in Github action" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 3ec4b21b1c438255df6f1652377011080dc28052. See: https://github.com/nodejs/node/issues/32257 PR-URL: https://github.com/nodejs/node/pull/32324 Reviewed-By: Matheus Marchini Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott Reviewed-By: Michael Dawson Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Richard Lau Reviewed-By: Michaƫl Zasso Reviewed-By: Matteo Collina Reviewed-By: Beth Griggs Reviewed-By: Gabriel Schulhof --- .github/workflows/ASAN.yml | 25 ------------------------- 1 file changed, 25 deletions(-) delete mode 100644 .github/workflows/ASAN.yml diff --git a/.github/workflows/ASAN.yml b/.github/workflows/ASAN.yml deleted file mode 100644 index 3c15c134ee5..00000000000 --- a/.github/workflows/ASAN.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: node ASAN - -on: [push, pull_request] - -jobs: - ubuntu-build: - runs-on: ubuntu-latest - container: gengjiawen/node-build:2020-02-14 - steps: - - uses: actions/checkout@v2 - - name: Build - # TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough - # memory to build with debug and ASAN. Allow this build to fail until - # we figure out a workaround, or until we update to 8.2 (where build - # is passing). - continue-on-error: true - run: | - npx envinfo - ./configure --debug --enable-asan --ninja && ninja -C out/Debug - - name: Test - env: - ASAN_OPTIONS: halt_on_error=0 - continue-on-error: true - run: | - python3 tools/test.py -J --mode=debug