From 1ffdbb6f423a7e1a3ae1f298e67c0f111443e629 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Fri, 9 Sep 2016 09:33:11 -0400 Subject: [PATCH] test: skip pseudo-tty/no_dropped_stdio test We had marked it as flaky but in some failures it hangs and does not seem to timeout, and or is reported as an error. Also add prefix to status file as it was missing. Also fix name of status file in testcfg.py. It was pointing to message.status instead of pseudo-tty.status. PR-URL: https://github.com/nodejs/node/pull/8470 Reviewed-By: James M Snell Reviewed-By: Santiago Gimeno --- test/pseudo-tty/pseudo-tty.status | 4 +++- test/pseudo-tty/testcfg.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/test/pseudo-tty/pseudo-tty.status b/test/pseudo-tty/pseudo-tty.status index 0d404171d27..27c6f75e106 100644 --- a/test/pseudo-tty/pseudo-tty.status +++ b/test/pseudo-tty/pseudo-tty.status @@ -1,3 +1,5 @@ +prefix pseudo-tty + [$system==aix] # test issue only, covered under https://github.com/nodejs/node/issues/7973 -no_dropped_stdio : PASS, FLAKY +no_dropped_stdio : SKIP diff --git a/test/pseudo-tty/testcfg.py b/test/pseudo-tty/testcfg.py index 46990315210..96b30253498 100644 --- a/test/pseudo-tty/testcfg.py +++ b/test/pseudo-tty/testcfg.py @@ -152,7 +152,7 @@ class TTYTestConfiguration(test.TestConfiguration): return ['sample', 'sample=shell'] def GetTestStatus(self, sections, defs): - status_file = join(self.root, 'message.status') + status_file = join(self.root, 'pseudo-tty.status') if exists(status_file): test.ReadConfigurationInto(status_file, sections, defs)