daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: update test-set-http-max-http-headers to use node:test 

This commit updates test/parallel/test-set-http-max-http-headers.js
to use node:test. This test already implemented a test runner, so
it makes sense to use the existing public API.

PR-URL: https://github.com/nodejs/node/pull/56439
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pull/56473/head
Colin Ihrig 2025-01-04 13:41:05 -05:00 committed by GitHub
parent 4a7b8157b5
commit 221040b629
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
test/parallel/test-set-http-max-http-headers.js
View File

@ -4,17 +4,10 @@ const common = require('../common');
const assert = require('assert');
const { spawn } = require('child_process');
const path = require('path');
const { suite, test } = require('node:test');
const testName = path.join(__dirname, 'test-http-max-http-headers.js');
const timeout = common.platformTimeout(100);
const tests = [];
function test(fn) {
tests.push(fn);
}
test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');
// Validate that the test fails if the max header size is too small.
@ -30,7 +23,7 @@ test(function(cb) {
}));
});
test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting success');
const env = Object.assign({}, process.env, {
@ -54,13 +47,13 @@ test(function(cb) {
}));
});
// Next, repeat the same checks using NODE_OPTIONS if it is supported.
if (!process.config.variables.node_without_node_options) {
const skip = process.config.variables.node_without_node_options;
suite('same checks using NODE_OPTIONS if it is supported', { skip }, () => {
const env = Object.assign({}, process.env, {
NODE_OPTIONS: '--max-http-header-size=1024'
});
test(function(cb) {
test(function(_, cb) {
console.log('running subtest expecting failure');
// Validate that the test fails if the max header size is too small.
@ -74,7 +67,7 @@ if (!process.config.variables.node_without_node_options) {
}));
});
test(function(cb) {
test(function(_, cb) {
// Validate that the test now passes if the same limit is large enough.
const args = ['--expose-internals', testName, '1024'];
const cp = spawn(process.execPath, args, { env, stdio: 'inherit' });
@ -85,18 +78,4 @@ if (!process.config.variables.node_without_node_options) {
cb();
}));
});
}
function runTest() {
const fn = tests.shift();
if (!fn) {
return;
}
fn(() => {
setTimeout(runTest, timeout);
});
}
runTest();
});