daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

dns: verify argument is valid function in resolve 

Don't use argument as callback if it's not a valid callback function.
Throw a valid exception instead explaining the issue. Adds to #7070
("DNS — Throw meaningful error(s)").
archived-io.js-v0.10
Kenan Sulayman 2014-02-07 18:18:27 +01:00 committed by Fedor Indutny
parent 56e80a37e0
commit 2ee86c624e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dns.js
View File

@ -184,9 +184,11 @@ exports.resolve = function(domain, type_, callback_) {
if (typeof type_ == 'string') { if (typeof type_ == 'string') {
resolver = resolveMap[type_]; resolver = resolveMap[type_];
callback = callback_; callback = callback_;
} else { } else if (util.isFunction(type_)) {
resolver = exports.resolve4; resolver = exports.resolve4;
callback = type_; callback = type_;
} else {
throw new Error('Type must be a string')
} }
if (typeof resolver === 'function') { if (typeof resolver === 'function') {