daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: replace anonymous closure functions with arrow function 

PR-URL: https://github.com/nodejs/node/pull/24417
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pull/24485/head
Amanpreet 2018-11-17 18:08:08 +05:30 committed by Rich Trott
parent c03c6e920f
commit 35b996d6e8
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-error-reporting.js
View File

@ -27,7 +27,7 @@ const fixtures = require('../common/fixtures');
function errExec(script, callback) {
const cmd = `"${process.argv[0]}" "${fixtures.path(script)}"`;
return exec(cmd, function(err, stdout, stderr) {
return exec(cmd, (err, stdout, stderr) => {
// There was some error
assert.ok(err);
@ -43,39 +43,39 @@ const syntaxErrorMessage = /\bSyntaxError\b/;
// Simple throw error
errExec('throws_error.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error.js', common.mustCall((err, stdout, stderr) => {
assert.ok(/blah/.test(stderr));
}));
// Trying to JSON.parse(undefined)
errExec('throws_error2.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error2.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));
// Trying to JSON.parse(undefined) in nextTick
errExec('throws_error3.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error3.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));
// throw ILLEGAL error
errExec('throws_error4.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error4.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));
// Specific long exception line doesn't result in stack overflow
errExec('throws_error5.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error5.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));
// Long exception line with length > errorBuffer doesn't result in assertion
errExec('throws_error6.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error6.js', common.mustCall((err, stdout, stderr) => {
assert.ok(syntaxErrorMessage.test(stderr));
}));
// Object that throws in toString() doesn't print garbage
errExec('throws_error7.js', common.mustCall(function(err, stdout, stderr) {
errExec('throws_error7.js', common.mustCall((err, stdout, stderr) => {
assert.ok(/<toString\(\) threw exception/.test(stderr));
}));