daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test_runner: refactor Promise chain in run() 

This commit refactors the chain of functions in run() to use an
async function instead of creating an awkward primordial-based
Promise chain.

PR-URL: https://github.com/nodejs/node/pull/55958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pull/55988/head
cjihrig 2024-11-22 15:54:03 -05:00 committed by Node.js GitHub Bot
parent 216fd206b6
commit 3c35188639
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/internal/test_runner/runner.js
View File

@ -17,7 +17,6 @@ const {
ArrayPrototypeSort, ArrayPrototypeSort,
ObjectAssign, ObjectAssign,
PromisePrototypeThen, PromisePrototypeThen,
PromiseResolve,
PromiseWithResolvers, PromiseWithResolvers,
SafeMap, SafeMap,
SafePromiseAll, SafePromiseAll,
@ -801,9 +800,17 @@ function run(options = kEmptyObject) {
} }
} }
const setupPromise = PromiseResolve(setup?.(root.reporter)); const runChain = async () => {
PromisePrototypeThen(PromisePrototypeThen(PromisePrototypeThen(setupPromise, runFiles), postRun), teardown); if (typeof setup === 'function') {
await setup(root.reporter);
}
await runFiles();
postRun?.();
teardown?.();
};
runChain();
return root.reporter; return root.reporter;
} }