mirror of https://github.com/nodejs/node.git
src: only set v8 flags if argc > 1
ParseArgs sets the first element of v8_args to argv[0], so v8_argc will always be at least 1. This change only calls V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional startup improvement of ~5%. PR-URL: https://github.com/nodejs/node/pull/2646 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>pull/2653/head
parent
112c527b74
commit
45fb34025d
|
@ -3688,7 +3688,7 @@ void Init(int* argc,
|
|||
#endif
|
||||
// The const_cast doesn't violate conceptual const-ness. V8 doesn't modify
|
||||
// the argv array or the elements it points to.
|
||||
if (v8_argc != 0)
|
||||
if (v8_argc > 1)
|
||||
V8::SetFlagsFromCommandLine(&v8_argc, const_cast<char**>(v8_argv), true);
|
||||
|
||||
// Anything that's still in v8_argv is not a V8 or a node option.
|
||||
|
|
Loading…
Reference in New Issue