daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: add issue reference to github pr template 

The PR template should include a Reference isssue (Fixes #issue_number)
so the PR can be tracked back to the issue easily.For a beginner trying
to read PRs to become comfortable with the codebase,it is really helpful
if one can directly reach the issue the PR fixes.

Fixes: https://github.com/nodejs/node/issues/36338

PR-URL: https://github.com/nodejs/node/pull/36440
Reviewed-By: James M Snell <jasnell@gmail.com>
pull/36099/head
Chinmoy Chakraborty 2020-12-08 16:37:51 +05:30 committed by James M Snell
parent b558075738
commit 4a6200e289
No known key found for this signature in database
GPG Key ID: 7341B15C070877AC
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -7,6 +7,10 @@ Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->
#### Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

4
doc/guides/contributing/pull-requests.md
View File

@ -281,6 +281,10 @@ Bug fixes and new features should include tests and possibly benchmarks.
Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->
#### Related Issues
Fixes: https://github.com/nodejs/node/issues/<issue_number>
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->