daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix encoding option on ReadStream, updated test

v0.7.4-release
Marco Rogers 2010-09-27 13:34:16 -04:00 committed by Ryan Dahl
parent c9627e0a0d
commit 4a7562d28f
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/fs.js
View File

@ -635,6 +635,8 @@ var ReadStream = fs.ReadStream = function(path, options) {
this[key] = options[key];
}
if(this.encoding) this.setEncoding(this.encoding);
if (this.start !== undefined || this.end !== undefined) {
if (this.start === undefined || this.end === undefined) {
this.emit('error',

3
test/simple/test-fs-read-stream.js
View File

@ -60,9 +60,8 @@ file2.destroy(function(err) {
callbacks.destroy++;
});
var file3 = fs.createReadStream(fn);
var file3 = fs.createReadStream(fn, {encoding: 'utf8'});
file3.length = 0;
file3.setEncoding('utf8');
file3.addListener('data', function(data) {
assert.equal("string", typeof(data));
file3.length += data.length;