daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

github: put description of PR to the end of tmpl 

It looks like github appends commit log right after the template
contents. Seeing this it does not look logical to ask for details first.

This commit puts `Description of change` part to the end of the
template.

PR-URL: https://github.com/nodejs/node/pull/5378
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
pull/5378/merge
Fedor Indutny 2016-02-23 00:38:24 -05:00
parent 65c0feb5fe
commit 4bd8b20f20
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,7 +1,3 @@
### Description of change
_Please provide a description of the change here._
### Pull Request check-list
_Please make sure to review and check all of these items:_
@ -14,11 +10,15 @@ _Please make sure to review and check all of these items:_
- [ ] Is a documentation update included (if this change modifies
existing APIs, or introduces new ones)?
_NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open._
_NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open._
### Affected core subsystem(s)
_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_
[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit
### Description of change
_Please provide a description of the change here._