From 5a56940d2cb23190cef116ea5cdb3c38c5f4d73f Mon Sep 17 00:00:00 2001 From: cjihrig Date: Wed, 7 Aug 2019 12:32:48 -0400 Subject: [PATCH] test: update postmortem metadata test for V8 7.7 The following metadata has changed: - v8dbg_class_ConsString__first__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__first_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_ConsString__second__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__second_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_SlicedString__offset__SMI - Class is now generated via torque. - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_ThinString__actual__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By: Colin Ihrig Reviewed-By: Ben Noordhuis Reviewed-By: Jiawen Geng Reviewed-By: Rich Trott --- test/v8-updates/test-postmortem-metadata.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 790d0dbb5c2..4a0667a97f9 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -62,8 +62,8 @@ function getExpectedSymbols() { 'v8dbg_bit_field3_number_of_own_descriptors_shift', 'v8dbg_class_Code__instruction_size__int', 'v8dbg_class_Code__instruction_start__uintptr_t', - 'v8dbg_class_ConsString__first__String', - 'v8dbg_class_ConsString__second__String', + 'v8dbg_class_ConsString__first_offset__int', + 'v8dbg_class_ConsString__second_offset__int', 'v8dbg_class_FixedArray__data__uintptr_t', 'v8dbg_class_FixedArrayBase__length__SMI', 'v8dbg_class_JSTypedArray__base_pointer__Object', @@ -104,10 +104,10 @@ function getExpectedSymbols() { 'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object', 'v8dbg_class_SharedFunctionInfo__script_or_debug_info__Object', 'v8dbg_class_UncompiledData__start_position__int32_t', - 'v8dbg_class_SlicedString__offset__SMI', + 'v8dbg_class_SlicedString__offset_offset__int', 'v8dbg_class_SlicedString__parent__String', 'v8dbg_class_String__length__int32_t', - 'v8dbg_class_ThinString__actual__String', + 'v8dbg_class_ThinString__actual_offset__int', 'v8dbg_context_idx_scope_info', 'v8dbg_context_idx_prev', 'v8dbg_context_min_slots',