daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repl: remove unnecessary check for globals 

There is no need to check for globals and also check if it is
an array.

PR-URL: https://github.com/nodejs/io.js/pull/1722
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
pull/1708/merge
Yazhong Liu 2015-05-18 01:25:19 +08:00 committed by cjihrig
parent fbaef40e63
commit 5f33521be5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/repl.js
View File

@ -624,7 +624,7 @@ REPLServer.prototype.complete = function(line, callback) {
completionGroupsLoaded(); completionGroupsLoaded();
} else { } else {
this.eval('.scope', this.context, 'repl', function(err, globals) { this.eval('.scope', this.context, 'repl', function(err, globals) {
if (err || !globals || !Array.isArray(globals)) { if (err || !Array.isArray(globals)) {
addStandardGlobals(completionGroups, filter); addStandardGlobals(completionGroups, filter);
} else if (Array.isArray(globals[0])) { } else if (Array.isArray(globals[0])) {
// Add grouped globals // Add grouped globals