daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: mention where to push security commits 

PR-URL: https://github.com/nodejs/node/pull/44691
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
pull/44739/head
RafaelGSS 2022-09-16 18:32:11 -03:00
parent 50329ae22d
commit 68a3618bb4
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
doc/contributing/releases.md
View File

@ -263,6 +263,19 @@ branch.
$ git checkout -b v1.2.3-proposal upstream/v1.x-staging
```
<details>
<summary>Security release</summary>
When performing Security Releases, the `vN.x.x-proposal` branch should be
branched off of `vN.x`.
```console
$ git checkout -b v1.2.3-proposal upstream/v1.x
git cherry-pick ... # cherry-pick nodejs-private PR commits directly into the proposal
```
</details>
### 3. Update `src/node_version.h`
Set the version for the proposed release using the following macros, which are
@ -458,6 +471,9 @@ Notable changes:
PR-URL: TBD
```
**Note**: Ensure to push the proposal branch to the nodejs-private repository.
Otherwise, you will leak the commits before the security release.
</details>
### 6. Propose release on GitHub