From 794e7be4f8f2a4e4b99599fe743421d04b3268fc Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Sat, 20 Nov 2010 20:45:30 -0800 Subject: [PATCH] Revert "Actually don't need to limit sendmsg size on unix - seems okay." This reverts commit 464ced4a86e89163ec68a0c2f020720dc82b0191. --- src/node_io_watcher.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/node_io_watcher.cc b/src/node_io_watcher.cc index 33e544340f0..a9477573f02 100644 --- a/src/node_io_watcher.cc +++ b/src/node_io_watcher.cc @@ -297,6 +297,10 @@ void IOWatcher::Dump() { unix_socket = true; } + // Unix sockets don't like huge messages. TCP sockets do. + // TODO: handle EMSGSIZE after sendmsg(). + size_t max_to_write = unix_socket ? 8*KB : 256*KB; + int fd_to_send = -1; // Offset is only as large as the first buffer of data. (See assert @@ -323,7 +327,7 @@ void IOWatcher::Dump() { // break if we've hit the end bucket_v->IsObject() && // break if iov contains a lot of data - to_write < 256*KB && + to_write < max_to_write && // break if iov is running out of space iovcnt < IOV_MAX; bucket_v = bucket->Get(next_sym), bucket_index++) {