daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Actually don't need to limit sendmsg size on unix - seems okay." 

This reverts commit 464ced4a86.
v0.7.4-release
Ryan Dahl 2010-11-20 20:45:30 -08:00
parent d42098651b
commit 794e7be4f8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/node_io_watcher.cc
View File

@ -297,6 +297,10 @@ void IOWatcher::Dump() {
unix_socket = true; unix_socket = true;
} }
// Unix sockets don't like huge messages. TCP sockets do.
// TODO: handle EMSGSIZE after sendmsg().
size_t max_to_write = unix_socket ? 8*KB : 256*KB;
int fd_to_send = -1; int fd_to_send = -1;
// Offset is only as large as the first buffer of data. (See assert // Offset is only as large as the first buffer of data. (See assert
@ -323,7 +327,7 @@ void IOWatcher::Dump() {
// break if we've hit the end // break if we've hit the end
bucket_v->IsObject() && bucket_v->IsObject() &&
// break if iov contains a lot of data // break if iov contains a lot of data
to_write < 256*KB && to_write < max_to_write &&
// break if iov is running out of space // break if iov is running out of space
iovcnt < IOV_MAX; iovcnt < IOV_MAX;
bucket_v = bucket->Get(next_sym), bucket_index++) { bucket_v = bucket->Get(next_sym), bucket_index++) {