From 7cd6a7ddcb006ff8c36bc2abe0a545167dd56dac Mon Sep 17 00:00:00 2001 From: Nikolai Vavilov Date: Fri, 3 Feb 2017 20:35:10 +0200 Subject: [PATCH] build: notify about the redundancy of "nosign" vcbuild doesn't sign by default since 92ed1ab45059e3c822dc661a4917bb5232707315, but there might be people who haven't noticed the change. This adds a message informing them that "nosign" is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/11119 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Sakthipriyan Vairamani --- vcbuild.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcbuild.bat b/vcbuild.bat index bc578c8f1d2..60ad3122831 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -51,7 +51,7 @@ if /i "%1"=="x64" set target_arch=x64&goto arg-ok if /i "%1"=="vc2015" set target_env=vc2015&goto arg-ok if /i "%1"=="noprojgen" set noprojgen=1&goto arg-ok if /i "%1"=="nobuild" set nobuild=1&goto arg-ok -if /i "%1"=="nosign" set "sign="&goto arg-ok +if /i "%1"=="nosign" set "sign="&echo Note: vcbuild no longer signs by default. "nosign" is redundant.&goto arg-ok if /i "%1"=="sign" set sign=1&goto arg-ok if /i "%1"=="nosnapshot" set nosnapshot=1&goto arg-ok if /i "%1"=="noetw" set noetw=1&goto arg-ok