mirror of https://github.com/nodejs/node.git
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: https://github.com/nodejs/node/issues/47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: https://github.com/nodejs/node/pull/47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/52293 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>pull/52505/head
parent
dee908be42
commit
8054f69dd9
|
@ -37,7 +37,7 @@
|
|||
|
||||
# Reset this number to 0 on major V8 upgrades.
|
||||
# Increment by one for each non-official patch applied to deps/v8.
|
||||
'v8_embedder_string': '-node.2',
|
||||
'v8_embedder_string': '-node.3',
|
||||
|
||||
##### V8 defaults for Node.js #####
|
||||
|
||||
|
|
|
@ -941,7 +941,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code")
|
|||
DEFINE_BOOL_READONLY(concurrent_sparkplug, false,
|
||||
"compile Sparkplug code in a background thread")
|
||||
#else
|
||||
DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT,
|
||||
DEFINE_BOOL(concurrent_sparkplug, false,
|
||||
"compile Sparkplug code in a background thread")
|
||||
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
|
||||
DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug)
|
||||
|
|
Loading…
Reference in New Issue