daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove usage of deprecated V8 APIs in addons 

PR-URL: https://github.com/nodejs/node/pull/22704
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pull/22450/head
Michaël Zasso 2018-09-05 14:48:42 +02:00
parent 1a57ad22d6
commit 8518548a79
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/addons/async-hello-world/binding.cc
View File

@ -73,7 +73,7 @@ void Method(const v8::FunctionCallbackInfo<v8::Value>& args) {
async_req* req = new async_req;
req->req.data = req;
req->input = args[0]->IntegerValue();
req->input = args[0].As<v8::Integer>()->Value();
req->output = 0;
req->isolate = isolate;
req->context = node::EmitAsyncInit(isolate, v8::Object::New(isolate), "test");

6
test/addons/buffer-free-callback/binding.cc
View File

@ -15,8 +15,8 @@ void Alloc(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::Isolate* isolate = args.GetIsolate();
alive++;
uintptr_t alignment = args[1]->IntegerValue();
uintptr_t offset = args[2]->IntegerValue();
uintptr_t alignment = args[1].As<v8::Integer>()->Value();
uintptr_t offset = args[2].As<v8::Integer>()->Value();
uintptr_t static_offset = reinterpret_cast<uintptr_t>(buf) % alignment;
char* aligned = buf + (alignment - static_offset) + offset;
@ -24,7 +24,7 @@ void Alloc(const v8::FunctionCallbackInfo<v8::Value>& args) {
args.GetReturnValue().Set(node::Buffer::New(
isolate,
aligned,
args[0]->IntegerValue(),
args[0].As<v8::Integer>()->Value(),
FreeCallback,
nullptr).ToLocalChecked());
}

2
test/addons/stringbytes-external-exceed-max/binding.cc
View File

@ -4,7 +4,7 @@
void EnsureAllocation(const v8::FunctionCallbackInfo<v8::Value> &args) {
v8::Isolate* isolate = args.GetIsolate();
uintptr_t size = args[0]->IntegerValue();
uintptr_t size = args[0].As<v8::Integer>()->Value();
v8::Local<v8::Boolean> success;
void* buffer = malloc(size);