daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: remove usage of a C++20 feature from V8 

We are not ready to compile with C++20 support yet.
This is only a DCHECK that can be removed without affecting the behavior
of release builds.

PR-URL: https://github.com/nodejs/node/pull/49639
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
pull/52505/head
Michaël Zasso 2023-08-10 19:09:38 +02:00 committed by marco-ippolito
parent b530214127
commit 856163e23c
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -37,7 +37,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.4',
'v8_embedder_string': '-node.5',
##### V8 defaults for Node.js #####

1
deps/v8/src/compiler/graph-visualizer.cc vendored
View File

@ -297,7 +297,6 @@ void JsonPrintAllSourceWithPositionsWasm(
os << "\"inlinings\": {";
for (size_t i = 0; i < positions.size(); ++i) {
if (i != 0) os << ", ";
DCHECK(source_map.contains(positions[i].inlinee_func_index));
size_t source_id = source_map.find(positions[i].inlinee_func_index)->second;
SourcePosition inlining_pos = positions[i].caller_pos;
os << '"' << i << "\": {\"inliningId\": " << i