util: fix inspecting error with a throwing getter for `cause`

PR-URL: https://github.com/nodejs/node/pull/47163
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
pull/47352/head
Antoine du Hamel 2023-03-31 18:27:52 +02:00 committed by GitHub
parent 841f6b3abf
commit 863ac8fa37
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 2 deletions

View File

@ -1243,9 +1243,16 @@ function getStackString(error) {
function getStackFrames(ctx, err, stack) {
const frames = StringPrototypeSplit(stack, '\n');
let cause;
try {
({ cause } = err);
} catch {
// If 'cause' is a getter that throws, ignore it.
}
// Remove stack frames identical to frames in cause.
if (err.cause && isError(err.cause)) {
const causeStack = getStackString(err.cause);
if (cause != null && isError(cause)) {
const causeStack = getStackString(cause);
const causeStackStart = StringPrototypeIndexOf(causeStack, '\n at');
if (causeStackStart !== -1) {
const causeFrames = StringPrototypeSplit(StringPrototypeSlice(causeStack, causeStackStart + 1), '\n');

View File

@ -46,3 +46,9 @@ process.nextTick(() => {
console.log(inspect(cause3));
console.log(inspect(error2));
});
{
const error = new Error('cause that throws');
Reflect.defineProperty(error, 'cause', { get() { throw new Error(); } });
console.log(inspect(error));
}

View File

@ -33,6 +33,16 @@ Error: undefined cause
at * {
[cause]: undefined
}
Error: cause that throws
at *
at *
at *
at *
at *
at *
at * {
[cause]: [Getter]
}
RangeError: New Stack Frames
at *
*[90m at *[39m {