mirror of https://github.com/nodejs/node.git
constants: freeze the constants object
Constants ought to be constant. The primary goal of this commit is to make constants exposed in require('constants') immutable, as they were prior to node@7.0.0, and as the constants exposed on fs.constants, crypto.constants, etc. are. Since this is implemented by using Object.freeze, it also has the side effect of making the entire exports of require('constants') immutable, so no new constants can be defined on the object in userland. PR-URL: https://github.com/nodejs/node/pull/19813 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>pull/20519/merge
parent
8444bba0af
commit
90e8f79f65
|
@ -32,3 +32,4 @@ Object.assign(exports,
|
|||
constants.os.signals,
|
||||
constants.fs,
|
||||
constants.crypto);
|
||||
Object.freeze(exports);
|
||||
|
|
|
@ -24,3 +24,5 @@ assert.ok(binding.crypto);
|
|||
}
|
||||
});
|
||||
});
|
||||
|
||||
assert.ok(Object.isFrozen(constants));
|
||||
|
|
Loading…
Reference in New Issue