daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc 

The code was changed in #48501 but the doc was missed.

PR-URL: https://github.com/nodejs/node/pull/49268
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
pull/49300/head
Cheng Zhao 2023-08-21 17:06:07 +09:00 committed by Michael Dawson
parent ee1f609a9e
commit 996f3904bc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/contributing/releases-node-api.md
View File

@ -9,7 +9,7 @@ release process.
* [0. Pre-release steps](#0-pre-release-steps)
* [1. Update the main branch](#1-update-the-main-branch)
* [2. Create a new branch for the release](#2-create-a-new-branch-for-the-release)
* [3. Update `NAPI_VERSION`](#3-update-napi_version)
* [3. Update `NODE_API_SUPPORTED_VERSION_MAX`](#3-update-node_api_supported_version_max)
* [4. Define `addon_context_register_func`](#4-define-addon_context_register_func)
* [5. Update version guards](#5-update-version-guards)
* [6. Create release commit](#6-create-release-commit)
@ -55,13 +55,13 @@ Create a new branch named `node-api-x-proposal`, off the main branch.
git checkout -b node-api-10-proposal upstream/main
```
### 3. Update `NAPI_VERSION`
### 3. Update `NODE_API_SUPPORTED_VERSION_MAX`
Set the version for the proposed release using the following macros, which are
already defined in `src/node_version.h`:
```c
#define NAPI_VERSION x
#define NODE_API_SUPPORTED_VERSION_MAX x
```
> Note: Do not update the `NAPI_VERSION` defined in `src/js_native_api.h`. It