daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

url: declare iterator inside loop 

Refs: https://github.com/nodejs/node/pull/30281#discussion_r343380565

PR-URL: https://github.com/nodejs/node/pull/30509
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
pull/30909/head
Kamat, Trivikram 2019-11-16 18:51:51 -08:00 committed by Bradley Farias
parent 916cc82b45
commit 9c32b24b65
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/url.js
View File

@ -166,8 +166,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
let end = -1;
let rest = '';
let lastPos = 0;
let i = 0;
for (let inWs = false, split = false; i < url.length; ++i) {
for (let i = 0, inWs = false, split = false; i < url.length; ++i) {
const code = url.charCodeAt(i);
// Find first and last non-whitespace characters for trimming
@ -299,7 +298,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
let hostEnd = -1;
let atSign = -1;
let nonHost = -1;
for (i = 0; i < rest.length; ++i) {
for (let i = 0; i < rest.length; ++i) {
switch (rest.charCodeAt(i)) {
case CHAR_TAB:
case CHAR_LINE_FEED:
@ -415,7 +414,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
let questionIdx = -1;
let hashIdx = -1;
for (i = 0; i < rest.length; ++i) {
for (let i = 0; i < rest.length; ++i) {
const code = rest.charCodeAt(i);
if (code === CHAR_HASH) {
this.hash = rest.slice(i);