daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: fix crash with SyntheticModule#setExport 

Use the new non-deprecated V8 API for that.

PR-URL: https://github.com/nodejs/node/pull/30062
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
pull/30108/head
Michaël Zasso 2019-10-22 15:28:34 +02:00 committed by Rich Trott
parent d29f0eda15
commit ab78d4df34
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/module_wrap.cc
View File

@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport(
Local<Value> export_value = args[1];
Local<Module> module = obj->module_.Get(isolate);
module->SetSyntheticModuleExport(export_name, export_value);
USE(module->SetSyntheticModuleExport(isolate, export_name, export_value));
}
void ModuleWrap::Initialize(Local<Object> target,

3
test/parallel/test-vm-module-synthetic.js
View File

@ -36,8 +36,6 @@ const assert = require('assert');
});
}
// https://bugs.chromium.org/p/v8/issues/detail?id=9828
/*
{
const s = new SyntheticModule([], () => {});
await s.link(() => {});
@ -47,7 +45,6 @@ const assert = require('assert');
name: 'ReferenceError',
});
}
*/
{
const s = new SyntheticModule([], () => {});