daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http: handle multiple Proxy-Authenticate values 

Just as the 'WWW-Authenticate' HTTP header the 'Proxy-Authenticate' header might
be received several times as well. Currently only one value is preserved. This
change allows to receive multiple values concatenated by space and comma.
pull/24504/head
thewilli 2012-09-24 11:18:05 +03:00 committed by Ben Noordhuis
parent a1ba29d110
commit ac17dc1764
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/http.js
View File

@ -401,6 +401,7 @@ IncomingMessage.prototype._addHeaderLine = function(field, value) {
case 'pragma': case 'pragma':
case 'link': case 'link':
case 'www-authenticate': case 'www-authenticate':
case 'proxy-authenticate':
case 'sec-websocket-extensions': case 'sec-websocket-extensions':
case 'sec-websocket-protocol': case 'sec-websocket-protocol':
if (field in dest) { if (field in dest) {

4
test/simple/test-http-server-multiheaders.js
View File

@ -31,6 +31,7 @@ var srv = http.createServer(function(req, res) {
assert.equal(req.headers.accept, 'abc, def, ghijklmnopqrst'); assert.equal(req.headers.accept, 'abc, def, ghijklmnopqrst');
assert.equal(req.headers.host, 'foo'); assert.equal(req.headers.host, 'foo');
assert.equal(req.headers['www-authenticate'], 'foo, bar, baz'); assert.equal(req.headers['www-authenticate'], 'foo, bar, baz');
assert.equal(req.headers['proxy-authenticate'], 'foo, bar, baz');
assert.equal(req.headers['x-foo'], 'bingo'); assert.equal(req.headers['x-foo'], 'bingo');
assert.equal(req.headers['x-bar'], 'banjo, bango'); assert.equal(req.headers['x-bar'], 'banjo, bango');
assert.equal(req.headers['sec-websocket-protocol'], 'chat, share'); assert.equal(req.headers['sec-websocket-protocol'], 'chat, share');
@ -57,6 +58,9 @@ srv.listen(common.PORT, function() {
['www-authenticate', 'foo'], ['www-authenticate', 'foo'],
['WWW-Authenticate', 'bar'], ['WWW-Authenticate', 'bar'],
['WWW-AUTHENTICATE', 'baz'], ['WWW-AUTHENTICATE', 'baz'],
['proxy-authenticate','foo'],
['Proxy-Authenticate','bar'],
['PROXY-AUTHENTICATE','baz'],
['x-foo', 'bingo'], ['x-foo', 'bingo'],
['x-bar', 'banjo'], ['x-bar', 'banjo'],
['x-bar', 'bango'], ['x-bar', 'bango'],