daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove SecureContext::operator* 

This rather mysterious operator is only used once and can easily be
replaced with ssl_ctx().

PR-URL: https://github.com/nodejs/node/pull/43121
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
pull/42601/head
Tobias Nießen 2022-05-17 18:19:34 +02:00 committed by GitHub
parent 2bc1991423
commit ace89d9a89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/crypto/crypto_common.cc
View File

@ -213,7 +213,7 @@ const char* GetServerName(SSL* ssl) {
}
bool SetGroups(SecureContext* sc, const char* groups) {
return SSL_CTX_set1_groups_list(**sc, groups) == 1;
return SSL_CTX_set1_groups_list(sc->ssl_ctx(), groups) == 1;
}
const char* X509ErrorCode(long err) { // NOLINT(runtime/int)

2
src/crypto/crypto_context.h
View File

@ -41,8 +41,6 @@ class SecureContext final : public BaseObject {
static void RegisterExternalReferences(ExternalReferenceRegistry* registry);
static SecureContext* Create(Environment* env);
SSL_CTX* operator*() const { return ctx_.get(); }
SSL_CTX* ssl_ctx() const { return ctx_.get(); }
SSLPointer CreateSSL();