daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: skip test if in FreeBSD jail 

Test test-net-socket-local-address is flaky in FreeBSD jail but robust
otherwise.

Fixes: https://github.com/nodejs/node/issues/2475
PR-URL: https://github.com/nodejs/node/pull/3995
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
pull/3995/merge
Rich Trott 2015-11-23 16:01:35 -08:00
parent d7b199d9e3
commit b061e3af55
2 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/parallel/parallel.status
View File

@ -19,4 +19,3 @@ test-child-process-exit-code : PASS,FLAKY
[$system==solaris] # Also applies to SmartOS [$system==solaris] # Also applies to SmartOS
[$system==freebsd] [$system==freebsd]
test-net-socket-local-address : PASS,FLAKY

20
test/parallel/test-net-socket-local-address.js
View File

@ -1,24 +1,30 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var net = require('net'); const net = require('net');
// skip test in FreeBSD jails
if (common.inFreeBSDJail) {
console.log('1..0 # Skipped: In a FreeBSD jail');
return;
}
var conns = 0; var conns = 0;
var clientLocalPorts = []; var clientLocalPorts = [];
var serverRemotePorts = []; var serverRemotePorts = [];
var server = net.createServer(function(socket) { const server = net.createServer(function(socket) {
serverRemotePorts.push(socket.remotePort); serverRemotePorts.push(socket.remotePort);
conns++; conns++;
}); });
var client = new net.Socket(); const client = new net.Socket();
server.on('close', function() { server.on('close', common.mustCall(function() {
assert.deepEqual(clientLocalPorts, serverRemotePorts, assert.deepEqual(clientLocalPorts, serverRemotePorts,
'client and server should agree on the ports used'); 'client and server should agree on the ports used');
assert.equal(2, conns); assert.equal(2, conns);
}); }));
server.listen(common.PORT, common.localhostIPv4, testConnect); server.listen(common.PORT, common.localhostIPv4, testConnect);