daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: guard test-doc recipe with node_use_openssl 

Currently, when configuring --without-ssl the test-doc target fails with
the following error:
/node/test/common/index.js:707
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
    at Object.assertCrypto (internal/util.js:97:11)
    at https.js:26:26
    at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
    ...
    at /node/tools/doc/versions.js:7:19
    at new Promise (<anonymous>)
    at getUrl (/node/tools/doc/versions.js:6:10)
Command: out/Release/node /node/test/doctool/test-doctool-html.js
[00:02|% 100|+   3|-   1]: Done
make: *** [test-doc] Error 1

This commit guards the test-doc recipe to not run if node was
configured without crypto support.

PR-URL: https://github.com/nodejs/node/pull/28199
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
pull/28239/head
Daniel Bevenius 2019-06-13 11:59:15 +02:00
parent 370873c59e
commit b456bbcc6d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Makefile
View File

@ -586,8 +586,12 @@ test-hash-seed: all
.PHONY: test-doc .PHONY: test-doc
test-doc: doc-only ## Builds, lints, and verifies the docs. test-doc: doc-only ## Builds, lints, and verifies the docs.
$(MAKE) lint @if [ "$(shell $(node_use_openssl))" != "true" ]; then \
$(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC) echo "Skipping test-doc (no crypto)"; \
else \
$(MAKE) lint; \
$(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC); \
fi
test-known-issues: all test-known-issues: all
$(PYTHON) tools/test.py $(PARALLEL_ARGS) known_issues $(PYTHON) tools/test.py $(PARALLEL_ARGS) known_issues