From bd0a690632268789a9c5611e90ea5255265e7cac Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Thu, 12 Apr 2018 07:35:13 +0200 Subject: [PATCH] test: fix warning in dlopen-ping-pong/binding.cc Currently, the following compiler warning is issued: ../binding.cc:26:27: warning: 'Utf8Value' is deprecated [-Wdeprecated-declarations] const String::Utf8Value filename(args[0]); ^ This commit updates the code to use the Isolate version. PR-URL: https://github.com/nodejs/node/pull/19966 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- test/addons/dlopen-ping-pong/binding.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/addons/dlopen-ping-pong/binding.cc b/test/addons/dlopen-ping-pong/binding.cc index b35db4e708d..a3b9af1b809 100644 --- a/test/addons/dlopen-ping-pong/binding.cc +++ b/test/addons/dlopen-ping-pong/binding.cc @@ -23,7 +23,7 @@ typedef const char* (*ping)(void); static ping ping_func; void LoadLibrary(const FunctionCallbackInfo& args) { - const String::Utf8Value filename(args[0]); + const String::Utf8Value filename(args.GetIsolate(), args[0]); void* handle = dlopen(*filename, RTLD_LAZY); assert(handle != nullptr); ping_func = reinterpret_cast(dlsym(handle, "dlopen_ping"));