mirror of https://github.com/nodejs/node.git
node: un-revert 9a6012e
The crashes in debug mode after adding Locker are *not* caused by Locker. Locker is merely exposing issues that already existed. Some of these issues have since been fixed inpull/24503/head70635753
. This reverts commit407181538b
. This reapplies commit9a6012edd9
. Conflicts: src/node.cc
parent
ebbd4039bc
commit
c33d3174b8
48
src/node.cc
48
src/node.cc
|
@ -2858,34 +2858,40 @@ int Start(int argc, char *argv[]) {
|
|||
// Use copy here as to not modify the original argv:
|
||||
Init(argc, argv_copy);
|
||||
|
||||
v8::V8::Initialize();
|
||||
v8::HandleScope handle_scope;
|
||||
V8::Initialize();
|
||||
{
|
||||
Locker locker;
|
||||
HandleScope handle_scope;
|
||||
|
||||
// Create the one and only Context.
|
||||
Persistent<v8::Context> context = v8::Context::New();
|
||||
v8::Context::Scope context_scope(context);
|
||||
// Create the one and only Context.
|
||||
Persistent<Context> context = Context::New();
|
||||
Context::Scope context_scope(context);
|
||||
|
||||
// Use original argv, as we're just copying values out of it.
|
||||
Handle<Object> process_l = SetupProcessObject(argc, argv);
|
||||
v8_typed_array::AttachBindings(context->Global());
|
||||
// Use original argv, as we're just copying values out of it.
|
||||
Handle<Object> process_l = SetupProcessObject(argc, argv);
|
||||
v8_typed_array::AttachBindings(context->Global());
|
||||
|
||||
// Create all the objects, load modules, do everything.
|
||||
// so your next reading stop should be node::Load()!
|
||||
Load(process_l);
|
||||
// Create all the objects, load modules, do everything.
|
||||
// so your next reading stop should be node::Load()!
|
||||
Load(process_l);
|
||||
|
||||
// All our arguments are loaded. We've evaluated all of the scripts. We
|
||||
// might even have created TCP servers. Now we enter the main eventloop. If
|
||||
// there are no watchers on the loop (except for the ones that were
|
||||
// uv_unref'd) then this function exits. As long as there are active
|
||||
// watchers, it blocks.
|
||||
uv_run(uv_default_loop());
|
||||
// All our arguments are loaded. We've evaluated all of the scripts. We
|
||||
// might even have created TCP servers. Now we enter the main eventloop. If
|
||||
// there are no watchers on the loop (except for the ones that were
|
||||
// uv_unref'd) then this function exits. As long as there are active
|
||||
// watchers, it blocks.
|
||||
uv_run(uv_default_loop());
|
||||
|
||||
EmitExit(process_l);
|
||||
RunAtExit();
|
||||
EmitExit(process_l);
|
||||
RunAtExit();
|
||||
|
||||
#ifndef NDEBUG
|
||||
// Clean up.
|
||||
context.Dispose();
|
||||
context.Dispose();
|
||||
#endif
|
||||
}
|
||||
|
||||
#ifndef NDEBUG
|
||||
// Clean up. Not strictly necessary.
|
||||
V8::Dispose();
|
||||
#endif // NDEBUG
|
||||
|
||||
|
|
Loading…
Reference in New Issue