daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

https: optimize https.createConnection() 

Stop using `arguments` for performance and readability.
pull/24504/head
Ryunosuke SATO 2012-12-28 12:40:06 +09:00 committed by Ben Noordhuis
parent a329729537
commit c4fc0febfa
1 changed files with 17 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/https.js
View File

@ -57,26 +57,25 @@ exports.createServer = function(opts, requestListener) {
// HTTPS agents.
function createConnection(/* [port, host, options] */) {
var options = {};
if (typeof arguments[0] === 'object') {
options = arguments[0];
} else if (typeof arguments[1] === 'object') {
options = arguments[1];
options.port = arguments[0];
} else if (typeof arguments[2] === 'object') {
options = arguments[2];
options.port = arguments[0];
options.host = arguments[1];
function createConnection(port, host, options) {
if (typeof port === 'object') {
options = port;
} else if (typeof host === 'object') {
options = host;
} else if (typeof options === 'object') {
options = options;
} else {
if (typeof arguments[0] === 'number') {
options.port = arguments[0];
options = {};
}
if (typeof arguments[1] === 'string') {
options.host = arguments[1];
if (typeof port === 'number') {
options.port = port;
}
if (typeof host === 'string') {
options.host = host;
}
return tls.connect(options);
}