daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

zlib: fix use after null when calling .close 

An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: https://github.com/nodejs/node/pull/5982
Fixes: https://github.com/nodejs/node/issues/6034
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
pull/6270/head
James Lal 2016-03-31 14:16:30 -07:00 committed by Anna Henningsen
parent e38bade828
commit c7fef3d3b8
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/zlib.js
View File

@ -474,7 +474,10 @@ function _close(engine, callback) {
engine._closed = true;
engine._handle.close();
// Caller may invoke .close after a zlib error (which will null _handle).
if (engine._handle) {
engine._handle.close();
}
}
function emitCloseNT(self) {