events: don't call once twice

Emitting an event within a `EventEmitter#once` callback of the same
event name will cause subsequent `EventEmitter#once` listeners of the
same name to be called multiple times.

    var emitter = new EventEmitter();

    emitter.once('e', function() {
      emitter.emit('e');
      console.log(1);
    });

    emitter.once('e', function() {
      console.log(2);
    });

    emitter.emit('e');

    // Output
    // 2
    // 1
    // 2

Fix the issue, by calling the listener method only if it was not
already called.
pull/37258/head
Tim Wood 2013-11-12 12:19:13 -08:00 committed by Fedor Indutny
parent ac9cf00252
commit c9d93f3431
2 changed files with 23 additions and 1 deletions

View File

@ -170,9 +170,15 @@ EventEmitter.prototype.once = function(type, listener) {
if (typeof listener !== 'function') if (typeof listener !== 'function')
throw TypeError('listener must be a function'); throw TypeError('listener must be a function');
var fired = false;
function g() { function g() {
this.removeListener(type, g); this.removeListener(type, g);
listener.apply(this, arguments);
if (!fired) {
fired = true;
listener.apply(this, arguments);
}
} }
g.listener = listener; g.listener = listener;

View File

@ -47,3 +47,19 @@ process.on('exit', function() {
assert.equal(1, times_hello_emited); assert.equal(1, times_hello_emited);
}); });
var times_recurse_emitted = 0;
e.once('e', function() {
e.emit('e');
times_recurse_emitted++;
});
e.once('e', function() {
times_recurse_emitted++;
});
e.emit('e');
process.on('exit', function() {
assert.equal(2, times_recurse_emitted);
});