daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Deprecate sendHeader() and writeHeader(), ppl should use writeHead()

pull/22966/head
Ryan Dahl 2010-05-12 12:15:58 -07:00
parent 7a2e6d674a
commit d0128787e7
1 changed files with 24 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
lib/http.js
View File

@ -183,8 +183,15 @@ IncomingMessage.prototype._parseQueryString = function () {
throw new Error("_parseQueryString is deprecated. Use require(\"querystring\") to parse query strings.\n");
};
var setBodyEncodingWarning;
IncomingMessage.prototype.setBodyEncoding = function (enc) {
// TODO deprecation message?
// deprecation message
if (!setBodyEncodingWarning) {
setBodyEncodingWarning = "setBodyEncoding has been renamed to setEncoding, please update your code.";
sys.error(setBodyEncodingWarning);
}
this.setEncoding(enc);
};
@ -446,9 +453,22 @@ ServerResponse.prototype.writeHead = function (statusCode) {
this.headWritten = true;
};
// TODO eventually remove sendHeader(), writeHeader()
ServerResponse.prototype.sendHeader = ServerResponse.prototype.writeHead;
ServerResponse.prototype.writeHeader = ServerResponse.prototype.writeHead;
// TODO Eventually remove
var sendHeaderWarning, writeHeaderWarning;
ServerResponse.prototype.sendHeader = function () {
if (!sendHeaderWarning) {
sendHeaderWarning = "sendHeader() has been renamed to writeHead()";
sys.error(sendHeaderWarning);
}
this.writeHead.apply(this, arguments);
};
ServerResponse.prototype.writeHeader = function () {
if (!writeHeaderWarning) {
writeHeaderWarning = "writeHeader() has been renamed to writeHead()";
sys.error(writeHeaderWarning);
}
this.writeHead.apply(this, arguments);
};
function ClientRequest (socket, method, url, headers) {
OutgoingMessage.call(this, socket);