From dbbfbe74caa8d5e76d32222735766435682b2b94 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 11 Apr 2013 13:18:02 +0200 Subject: [PATCH] cluster: fix O(n*m) scan of cmd string Don't scan the whole string for a "NODE_CLUSTER_" substring, just check that the string starts with the expected prefix. The linear scan was causing a noticeable (but unsurprising) slowdown on messages with a large .cmd string property. --- lib/cluster.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/cluster.js b/lib/cluster.js index 5561c9fbcf4..5245ab02a4f 100644 --- a/lib/cluster.js +++ b/lib/cluster.js @@ -141,9 +141,10 @@ cluster.setupMaster = function(options) { // Check if a message is internal only var INTERNAL_PREFIX = 'NODE_CLUSTER_'; function isInternalMessage(message) { - return (isObject(message) && + return isObject(message) && typeof message.cmd === 'string' && - message.cmd.indexOf(INTERNAL_PREFIX) === 0); + message.cmd.length > INTERNAL_PREFIX.length && + message.cmd.slice(0, INTERNAL_PREFIX.length) === INTERNAL_PREFIX; } // Modify message object to be internal