mirror of https://github.com/nodejs/node.git
node: don't check return value of unsetenv()
It returns void on some platforms, notably FreeBSD.pull/24503/head
parent
bc834c395b
commit
dee8c51547
12
src/node.cc
12
src/node.cc
|
@ -1937,12 +1937,9 @@ static Handle<Boolean> EnvDeleter(Local<String> property,
|
|||
HandleScope scope;
|
||||
#ifdef __POSIX__
|
||||
String::Utf8Value key(property);
|
||||
// prototyped as `void unsetenv(const char*)` on some platforms
|
||||
if (unsetenv(*key) < 0) {
|
||||
// Deletion failed. Return true if the key wasn't there in the first place,
|
||||
// false if it is still there.
|
||||
return scope.Close(Boolean::New(getenv(*key) == NULL));
|
||||
};
|
||||
if (!getenv(*key)) return False();
|
||||
unsetenv(*key); // can't check return value, it's void on some platforms
|
||||
return True();
|
||||
#else
|
||||
String::Value key(property);
|
||||
WCHAR* key_ptr = reinterpret_cast<WCHAR*>(*key);
|
||||
|
@ -1953,9 +1950,8 @@ static Handle<Boolean> EnvDeleter(Local<String> property,
|
|||
GetLastError() != ERROR_SUCCESS;
|
||||
return scope.Close(Boolean::New(rv));
|
||||
}
|
||||
return True();
|
||||
#endif
|
||||
// It worked
|
||||
return v8::True();
|
||||
}
|
||||
|
||||
|
||||
|
|
Loading…
Reference in New Issue