daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: V8: cherry-pick 215ccd593edb 

Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: 215ccd593e
PR-URL: https://github.com/nodejs/node/pull/47212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
pull/47248/head
Joyee Cheung 2023-03-24 18:30:56 +01:00 committed by GitHub
parent 5e72051456
commit f5239795b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
deps/v8/src/common/checks.h vendored
View File

@ -15,7 +15,7 @@
#ifdef ENABLE_SLOW_DCHECKS
#define SLOW_DCHECK(condition) \
CHECK(!v8::internal::v8_flags.enable_slow_asserts || (condition))
CHECK(!v8::internal::v8_flags.enable_slow_asserts.value() || (condition))
#define SLOW_DCHECK_IMPLIES(lhs, rhs) SLOW_DCHECK(!(lhs) || (rhs))
#else
#define SLOW_DCHECK(condition) ((void)0)