daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: unskip v8-updates/test-linux-perf-logger 

Refs: https://github.com/nodejs/node/issues/51308
Refs: https://github.com/nodejs/node/pull/52821
PR-URL: https://github.com/nodejs/node/pull/52869
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
pull/53148/head
Luke Albao 2024-05-06 18:17:21 -07:00 committed by Richard Lau
parent c0c598d753
commit f671dcb865
No known key found for this signature in database
GPG Key ID: C43CEC45C17AB93C
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/v8-updates/test-linux-perf-logger.js
View File

@ -20,7 +20,11 @@
//
// NOTE: This test runs only on linux, as that is the only platform supported by perf, and
// accordingly the only platform where `perf-basic-prof*` v8 flags are available.
//
// MAINTAINERS' NOTE: As of early 2024, the most common failure mode for this test suite
// is for v8 options to change from version to version. If this suite fails, look there first.
// We use options to forcibly require certain test cases to JIT code, and the nodeFlags to do
// so can change.
const common = require('../common');
if (!common.isLinux) {
@ -48,7 +52,8 @@ const testCases = [
},
{
title: '--perf-basic-prof compiled',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'test-regex',
'~functionOne .+/linux-perf-logger.js',
@ -66,7 +71,8 @@ const testCases = [
},
{
title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan'],
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',