Commit Graph

20 Commits (24ed8da48ee11b0d4130f1c71a448db59c83f607)

Author SHA1 Message Date
devstone 3111ed7011
stream: handle undefined chunks correctly in decode stream
Align TextDecoderStream behavior with WPT requirements by treating
undefined chunks as errors. This change ensures that TextDecoderStream
properly handles unexpected chunk types and throws an error when
receiving undefined input.

This update addresses the failing WPT for decode stream error handling.

PR-URL: https://github.com/nodejs/node/pull/55153
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
2024-09-30 17:54:43 +00:00
Yagiz Nizipli 99ac8829cf
test: update encoding web-platform tests
PR-URL: https://github.com/nodejs/node/pull/53477
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-06-18 19:39:49 +00:00
Mattias Buelens e870941fa4
test: enable idlharness tests for encoding
TextDecoderStream and TextEncoderStream are now exposed as globals,
so we can run the entire Encoding idlharness test suite.

PR-URL: https://github.com/nodejs/node/pull/50778
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-11-20 12:07:55 +00:00
legendecas a00f0b1f0a test: recognize wpt completion error
PR-URL: https://github.com/nodejs/node/pull/50429
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2023-11-03 16:04:32 +00:00
Filip Skokan 31e046b9dd
test: update encoding WPTs
PR-URL: https://github.com/nodejs/node/pull/46802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2023-02-25 17:30:35 +00:00
Filip Skokan 4d36ebddda
test: enable api-invalid-label.any.js in encoding WPTs
PR-URL: https://github.com/nodejs/node/pull/46506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2023-02-07 10:39:36 +00:00
Yagiz Nizipli 8467aa2189
test: update encoding wpt to latest
PR-URL: https://github.com/nodejs/node/pull/45850
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-12-17 08:18:21 +00:00
Kohei Ueno 86088ab78e
lib: fix TypeError when converting a detached buffer source
PR-URL: https://github.com/nodejs/node/pull/44020
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-11-01 23:59:26 +00:00
Filip Skokan c3ff198a77
test: update WPT runner
PR-URL: https://github.com/nodejs/node/pull/43455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2022-08-10 12:39:20 +00:00
Kohei Ueno c8bea71bba
stream: update TextEncoderStream to align the latest spec
PR-URL: https://github.com/nodejs/node/pull/44101
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-08-04 22:41:28 +00:00
Kohei Ueno 536df6a439
test: update WPT encoding tests
PR-URL: https://github.com/nodejs/node/pull/43958
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-25 16:12:05 +01:00
Michaël Zasso 0c11f2ee06
test: update all Web Platform Tests
PR-URL: https://github.com/nodejs/node/pull/37467
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2021-03-03 22:16:32 +01:00
Michael Dawson 9603e4a08d test: update to improve terminology
Update common section in wpt to incorporate
improved terminology fixed upstream in
https://github.com/web-platform-tests/wpt/pull/27152

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/37011
Reviewed-By: Milad Fa <mfarazma@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-01-26 19:08:36 -08:00
Michaël Zasso eb9d7a437e test: update WPT harness and tests
PR-URL: https://github.com/nodejs/node/pull/33770
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2020-09-16 06:23:39 +00:00
Anna Henningsen 237be2ed9e
encoding: make TextDecoder handle BOM correctly
Do not accept the BOM if it comes from a different encoding, and
only discard the BOM after it has actually been read (including
when it is spread over multiple chunks in streaming mode).

Fixes: https://github.com/nodejs/node/issues/25315

PR-URL: https://github.com/nodejs/node/pull/30132
Reviewed-By: Gus Caplan <me@gus.host>
2019-11-05 20:19:09 +01:00
Anna Henningsen 7c9ee6dd88
util: add encodeInto to TextEncoder
Add function encodeInto to TextEncoder, and add MessageChannel
to the encodeInto.any.js test.

Fixes: https://github.com/nodejs/node/issues/28851
Fixes: https://github.com/nodejs/node/issues/26904
Refs: https://github.com/nodejs/node/pull/28862
Co-authored-by: AtticusYang <yyongtai@163.com>

PR-URL: https://github.com/nodejs/node/pull/29524
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2019-09-13 20:27:18 +02:00
Joyee Cheung aa42d378b1 test: expect wpt/encoding/encodeInto.any.js to fail
Since we do not implement TextEncoder.prototype.encodeInto

PR-URL: https://github.com/nodejs/node/pull/27860
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-05-28 05:28:36 +02:00
Joyee Cheung 86ed4ada7f test: expect wpt/encoding/streams to fail
Since we do not implement TextDecoderStream or TextEncoderStream.

PR-URL: https://github.com/nodejs/node/pull/27860
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-05-28 05:28:04 +02:00
Joyee Cheung 16dfa0f309
test: use WPT runner to run encoding tests
PR-URL: https://github.com/nodejs/node/pull/25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-01-10 19:54:58 +08:00
Joyee Cheung 8906e5209b
test: pull enconding WPT test fixtures
PR-URL: https://github.com/nodejs/node/pull/25321
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-01-10 19:54:55 +08:00