daohualiuxiang
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,892 Commits
48 Branches
862 Tags
2 GiB
Commit Graph

3 Commits (678480e328c1fdd152973695e978e0f02b489770)

Author SHA1 Message Date
Bartosz Sosnowski d5bc52aa2e benchmark: use 'yes' instead of echo in a loop 
This changes child-process-exec-stdout benchmark to use 'yes' instead
of echo in a while loop. This makes this benchmark consistent with
child-process-read which already uses `yes` and allows this benchmark
to be executed on Windows.

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/node/pull/8721
 2016-09-26 17:23:50 +02:00
Bartosz Sosnowski 5386b23f64 benchmark: fix child-process-exec-stdout on win 
This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.

PR-URL: https://github.com/nodejs/node/pull/7178
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
 2016-06-10 17:30:28 +02:00
Rich Trott c9a5990a76 child_process: measure buffer length in bytes 
This change fixes a known issue where `maxBuffer` limits by characters
rather than bytes. Benchmark added to confirm no performance regression
occurs with this change.

PR-URL: https://github.com/nodejs/node/pull/6764
Fixes: https://github.com/nodejs/node/issues/1901
Reviewed-By: Brian White <mscdex@mscdex.net>
 2016-05-25 10:57:59 -07:00