Commit Graph

3 Commits (70069b21a2fb5b20312ede903cbaa71b20c6d90a)

Author SHA1 Message Date
Michaël Zasso 238104c531
test: move execution of WPT to worker threads
Running outside of the main Node.js context prevents us from upgrading
the WPT harness because new versions more aggressively check the
identity of globals like error constructors. Instead of exposing
globals used by the tests on vm sandboxes, use worker threads to run
everything.

PR-URL: https://github.com/nodejs/node/pull/34796
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2020-08-18 12:53:14 +02:00
Rich Trott 556de23dfb test: remove unneeded `--expose-internals`
test/wpt/test-timers.js does not appear to need the `--expose-internals`
flag. Remove it.

PR-URL: https://github.com/nodejs/node/pull/27608
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2019-05-10 08:03:41 -07:00
Joyee Cheung d9066bef2c
test: run html/webappapis/timers WPT
PR-URL: https://github.com/nodejs/node/pull/25618
Reviewed-By: James M Snell <jasnell@gmail.com>
2019-02-01 00:52:00 +08:00