daohualiuxiang/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	2013-02-21 15:23:18 -08:00
isaacs	abbd47e4a3	test: Update simple/test-fs-{write,read}-stream-err for streams2 Streams2 style streams might have already kicked off a read() or write() before emitting 'data' events. Make the test less dependent on ordering of when data events occur.	2012-12-14 17:46:23 -08:00
Ben Noordhuis	6e97b2cc17	fs: fix ReadStream fd leak Close the file descriptor when a read operation fails. Fixes #4387.	2012-12-12 09:46:22 +01:00

Author

SHA1

Message

Date

isaacs

3b2e9d2648

stream: remove lowWaterMark feature

It seems like a good idea on the face of it, but lowWaterMarks are
actually not useful, and in practice should always be set to zero.

It would be worthwhile for writers if we actually did some kind of
writev() type of thing, but actually this just delays calling write()
and the overhead of doing a bunch of Buffer copies is not worth the
slight benefit of calling write() fewer times.

2013-02-21 15:23:18 -08:00

isaacs

abbd47e4a3

test: Update simple/test-fs-{write,read}-stream-err for streams2

Streams2 style streams might have already kicked off a read() or write()
before emitting 'data' events.  Make the test less dependent on ordering
of when data events occur.

2012-12-14 17:46:23 -08:00

Ben Noordhuis

6e97b2cc17

fs: fix ReadStream fd leak

Close the file descriptor when a read operation fails.

Fixes #4387.

2012-12-12 09:46:22 +01:00

3 Commits (74ef94907277d8aa29d23cef29aee25161960376)