Commit Graph

43192 Commits (8975748527a82d2dcfd6168ada30359f39de91ba)

Author SHA1 Message Date
Marco Ippolito ecc9fb2f8e
lib: add typescript support to STDIN eval
PR-URL: https://github.com/nodejs/node/pull/56359
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2024-12-29 22:42:51 +00:00
Bart Louwers 0dbbabab95
sqlite: pass conflict type to conflict resolution handler
PR-URL: https://github.com/nodejs/node/pull/56352
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-12-29 17:37:54 +00:00
Node.js GitHub Bot 67b647edc7
deps: update undici to 7.2.0
PR-URL: https://github.com/nodejs/node/pull/56335
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-12-28 22:27:40 +00:00
Luigi Pinca cef15f8a03
test: remove flaky designation
Remove test-inspector-async-stack-traces-set-interval flaky designation.

Refs: https://github.com/nodejs/node/issues/50243
PR-URL: https://github.com/nodejs/node/pull/56369
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-12-28 22:15:32 +00:00
Node.js GitHub Bot ca3c8f1438
deps: update googletest to e54519b
PR-URL: https://github.com/nodejs/node/pull/56370
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-28 15:05:12 +00:00
Giovanni 91c6b8a38e assert: make partialDeepStrictEqual throw when comparing [0] with [-0]
Fixes: https://github.com/nodejs/node/issues/56230
PR-URL: https://github.com/nodejs/node/pull/56237
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
2024-12-28 16:50:20 +08:00
Luigi Pinca 7d7e2cec25
test: remove test-worker-arraybuffer-zerofill flaky designation
Refs: https://github.com/nodejs/node/pull/56053
PR-URL: https://github.com/nodejs/node/pull/56364
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-12-28 07:48:35 +00:00
Luigi Pinca 38cd81aea4
test: remove test-net-write-fully-async-hex-string flaky designation
The original issue is likely the same as other tests that time out.

Refs: https://github.com/nodejs/node/issues/54918
Refs: https://github.com/nodejs/node/commit/84c2e712ebcd0f32dc0e
RefS: https://github.com/nodejs/node/pull/52959
PR-URL: https://github.com/nodejs/node/pull/56365
Refs: https://github.com/nodejs/node/pull/52959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
2024-12-28 04:31:17 +00:00
Kevin Gibbons 94191f7b09
doc: expand description of `parseArg`'s `default`
PR-URL: https://github.com/nodejs/node/pull/54431
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
2024-12-27 19:17:55 +00:00
Marco Ippolito ba5992831b
module: unflag --experimental-strip-types
PR-URL: https://github.com/nodejs/node/pull/56350
Fixes: https://github.com/nodejs/typescript/issues/17
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2024-12-26 18:46:06 +00:00
Edy Silva c94a9dbc40
test: improve abort signal dropping test
PR-URL: https://github.com/nodejs/node/pull/56339
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
2024-12-26 14:57:17 +00:00
Marco Ippolito c0edd30414
test: enable ts test on win arm64
PR-URL: https://github.com/nodejs/node/pull/56349
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-26 07:55:27 +00:00
Antoine du Hamel 1d1d8f2df3
url: use resolved path to convert UNC paths to URL
PR-URL: https://github.com/nodejs/node/pull/56302
Fixes: https://github.com/nodejs/node/issues/56262
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
2024-12-25 19:42:11 +01:00
Node.js GitHub Bot b420c8fce2
meta: move one or more collaborators to emeritus
PR-URL: https://github.com/nodejs/node/pull/56342
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-12-25 16:20:00 +00:00
Antoine du Hamel f9fb410f88
doc: use `<ul>` instead of `<ol>` in `SECURITY.md`
PR-URL: https://github.com/nodejs/node/pull/56346
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-12-25 13:17:41 +01:00
Matteo Collina 7ca753166f
doc: clarify that WASM is trusted
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/56345
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-25 11:22:25 +00:00
Luigi Pinca d00710dd8d
test: deflake test-watch-file-shared-dependency
Delay dependency file modification on macOS.

Refs: https://github.com/nodejs/node/pull/51842
PR-URL: https://github.com/nodejs/node/pull/56344
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-25 08:54:37 +00:00
Michaël Zasso 3147ec2400
doc: update macOS and Xcode versions for releases
This is just documenting the current state, not changing it.

PR-URL: https://github.com/nodejs/node/pull/56337
Refs: https://ci-release.nodejs.org/job/iojs+release/10689/nodes=osx13-x64-release-tar/consoleFull
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-12-25 07:12:23 +00:00
ishabi 821b0a733e
src: use starts_with in fs_permission.cc
PR-URL: https://github.com/nodejs/node/pull/55811
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
2024-12-25 03:33:32 +00:00
Kevin Toshihiro Uehara bd0b704d3c
doc: fix the `crc32` documentation
PR-URL: https://github.com/nodejs/node/pull/55898
Fixes: https://github.com/nodejs/node/issues/55800
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-24 21:53:53 +01:00
Antoine du Hamel 49acdc8748
test: skip `test-sqlite-extensions` when SQLite is not built by us
PR-URL: https://github.com/nodejs/node/pull/56341
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2024-12-24 20:19:12 +01:00
Marco Ippolito da3f388c14
module: support eval with ts syntax detection
PR-URL: https://github.com/nodejs/node/pull/56285
Refs: https://github.com/nodejs/typescript/issues/17
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2024-12-24 16:48:02 +00:00
Michael Dawson be9dc2d0af test: increase spin for eventloop test on s390
It was excluded as it was failing intermittently. Likely
that s390 was just so fast times were rounded down to 0.

Increase the spin time on s390x only.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/56228
Refs: https://github.com/nodejs/node/issues/41286
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-12-24 09:06:21 -05:00
jakecastelli 5ea6fa711e test: add coverage for pipeline
co-authored-by: jazelly <xzha4350@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/56278
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2024-12-24 13:30:55 +00:00
jakecastelli 6156f8a6d5 Revert "stream: handle generator destruction from Duplex.from()"
This reverts commit 55413004c8.

PR-URL: https://github.com/nodejs/node/pull/56278
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2024-12-24 13:30:54 +00:00
Yiyun Lei a9e65f61d4
test: migrate message eval tests from Python to JS
Migrate the eval tests in the `test/message` folder from Python to JS.

PR-URL: https://github.com/nodejs/node/pull/50482
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2024-12-24 09:03:50 +01:00
Node.js GitHub Bot 270a2f14aa
deps: update ngtcp2 to 1.10.0
PR-URL: https://github.com/nodejs/node/pull/56334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-12-24 00:59:16 +00:00
Node.js GitHub Bot 657716694d
deps: update simdutf to 5.7.0
PR-URL: https://github.com/nodejs/node/pull/56332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-24 00:59:09 +00:00
Marco Ippolito 56d58654ed
test: check typescript loader
PR-URL: https://github.com/nodejs/node/pull/54657
Refs: https://github.com/nodejs/node/issues/54645
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-12-23 20:34:19 +00:00
Antoine du Hamel 48c75bc02b
tools: fix `require-common-first` lint rule from subfolder
PR-URL: https://github.com/nodejs/node/pull/56325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2024-12-22 18:44:20 +00:00
Cheng 31c20f6e52 build: fix GN build for ngtcp2
PR-URL: https://github.com/nodejs/node/pull/56300
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-12-22 21:56:54 +10:30
Bart Louwers b814038447
doc: add entry to changelog about SQLite Session Extension
PR-URL: https://github.com/nodejs/node/pull/56318
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-12-21 19:06:38 +00:00
Antoine du Hamel 821ab6ff30
tools: add release line label when opening release proposal
PR-URL: https://github.com/nodejs/node/pull/56317
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2024-12-21 15:29:41 +00:00
Chengzhong Wu 4fd5db479a
module: use buffer.toString base64
`btoa` only supports latin-1 charset and produces invalid source
mapping urls.

PR-URL: https://github.com/nodejs/node/pull/56315
Refs: https://github.com/nodejs/node/issues/56296
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-12-21 11:02:30 +00:00
Michaël Zasso d780b90b58
build: test macos-13 on GitHub actions
We are in the process of updating macOS to version 13 in the
Jenkins CI, but unfortunately this is taking longer than expected.
Add it to the GitHub actions test matrix so that we have some coverage.

Refs: https://github.com/nodejs/build/issues/3686
PR-URL: https://github.com/nodejs/node/pull/56307
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-12-20 16:35:29 +00:00
Vladimir Morozov ca69d0a2c3
node-api: remove deprecated attribute from napi_module_register
PR-URL: https://github.com/nodejs/node/pull/56162
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
2024-12-20 16:22:34 +00:00
Chengzhong Wu b6df12819d
esm: add experimental support for addon modules
PR-URL: https://github.com/nodejs/node/pull/55844
Fixes: https://github.com/nodejs/node/issues/40541
Fixes: https://github.com/nodejs/node/issues/55821
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-20 11:59:08 +00:00
Jason Zhang 57b21b16d2
stream: validate undefined sizeAlgorithm in WritableStream
PR-URL: https://github.com/nodejs/node/pull/56067
Fixes: https://github.com/nodejs/node/issues/56014
Refs: https://github.com/whatwg/streams/pull/1333
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-20 06:57:34 +00:00
Luigi Pinca 14803eaa9a
test: remove async-hooks/test-writewrap flaky designation
The issue is the same as other tests that time out.

Refs: https://github.com/nodejs/node/issues/54918
Refs: https://github.com/nodejs/node/pull/54802
PR-URL: https://github.com/nodejs/node/pull/56048
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2024-12-20 06:49:20 +00:00
Colin Ihrig 219b900384
test_runner,cli: mark test isolation as stable
This commit stabilizes test isolation configuration in the
test runner.

PR-URL: https://github.com/nodejs/node/pull/56298
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-20 02:10:26 +00:00
Chengzhong Wu 28557ef5f1
lib: optimize `prepareStackTrace` on builtin frames
Only invalidates source map lookup cache when a new source map is found.
This improves when user codes interleave with builtin functions, like
`array.map`.

PR-URL: https://github.com/nodejs/node/pull/56299
Refs: https://github.com/nodejs/node/issues/56296
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2024-12-20 01:13:31 +01:00
Chengzhong Wu a33ec1248b
lib: suppress source map lookup exceptions
When the source map data are invalid json strings, skip construct
`SourceMap` on it. Additionally, suppress exceptions on source map
lookups and fix test runners crash on invalid source maps.

PR-URL: https://github.com/nodejs/node/pull/56299
Refs: https://github.com/nodejs/node/issues/56296
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2024-12-20 01:12:55 +01:00
Luigi Pinca 990497c514
test: deflake test-esm-loader-hooks-inspect-brk
Refs: https://github.com/nodejs/node/pull/54827
Refs: https://github.com/nodejs/node/pull/51560
PR-URL: https://github.com/nodejs/node/pull/56050
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-12-19 22:30:28 +00:00
Antoine du Hamel 854d23b0d6
2024-12-19, Version 23.5.0 (Current)
Notable changes:

crypto:
  * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) https://github.com/nodejs/node/pull/56142
dgram:
  * (SEMVER-MINOR) support blocklist in udp (theanarkh) https://github.com/nodejs/node/pull/56087
doc:
  * stabilize util.styleText (Rafael Gonzaga) https://github.com/nodejs/node/pull/56265
module:
  * (SEMVER-MINOR) add prefix-only modules to `module.builtinModules` (Jordan Harband) https://github.com/nodejs/node/pull/56185
  * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) https://github.com/nodejs/node/pull/56194
  * (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) https://github.com/nodejs/node/pull/55698
  * (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) https://github.com/nodejs/node/pull/55698
report:
  * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) https://github.com/nodejs/node/pull/56068
sqlite:
  * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) https://github.com/nodejs/node/pull/56213
src,lib:
  * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) https://github.com/nodejs/node/pull/56201

PR-URL: https://github.com/nodejs/node/pull/56310
2024-12-19 19:51:48 +01:00
origranot a85ef6a04a test: add test case for listeners
PR-URL: https://github.com/nodejs/node/pull/56282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-19 18:16:49 +01:00
origranot 58b72040f2 Revert "events: add hasEventListener util for validate"
This reverts commit https://github.com/nodejs/node/commit/bdb6d12.

PR-URL: https://github.com/nodejs/node/pull/56282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2024-12-19 18:16:48 +01:00
Antoine du Hamel ec6e6b534c
test: make `test-permission-sqlite-load-extension` more robust
PR-URL: https://github.com/nodejs/node/pull/56295
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
2024-12-19 17:11:19 +00:00
jakecastelli fd8de670da
stream: catch and forward error from dest.write
PR-URL: https://github.com/nodejs/node/pull/55270
Fixes: https://github.com/nodejs/node/issues/54945
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-12-19 11:49:34 +00:00
Antoine du Hamel 0675e05a04
doc: fix links in `module.md`
PR-URL: https://github.com/nodejs/node/pull/56283
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-12-19 10:34:42 +00:00
Joyee Cheung 756077867b
build: build v8 with -fvisibility=hidden on macOS
V8 should be built with -fvisibility=hidden, otherwise
the resulting binary would contain unnecessary symbols. In
particular, on macOS, this leads to 5000+ weak symbols
resolved at runtime, leading to a startup regression.

On macOS this also reduces the binary size about ~10MB.

It's only enabled on macOS in this patch as gcc can time out
or run out of memory on some machines in the CI with
-fvisibility=hidden.

PR-URL: https://github.com/nodejs/node/pull/56275
Fixes: https://github.com/nodejs/performance/issues/180
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-12-19 03:24:51 +00:00