0dcbecd32b
crypto: fix uninitialized memory access in openssl
...
ASN1_STRING_to_UTF8() passes an ASN1_STRING to ASN1_STRING_set() but forgot to
initialize the `length` field.
Fixes the following valgrind error:
$ valgrind -q --track-origins=yes --num-callers=19 \
out/Debug/node test/simple/test-tls-client-abort.js
==2690== Conditional jump or move depends on uninitialised value(s)
==2690== at 0x784B69: ASN1_STRING_set (asn1_lib.c:382)
==2690== by 0x809564: ASN1_mbstring_ncopy (a_mbstr.c:204)
==2690== by 0x8090F0: ASN1_mbstring_copy (a_mbstr.c:86)
==2690== by 0x782F1F: ASN1_STRING_to_UTF8 (a_strex.c:570)
==2690== by 0x78F090: asn1_string_canon (x_name.c:409)
==2690== by 0x78EF17: x509_name_canon (x_name.c:354)
==2690== by 0x78EA7D: x509_name_ex_d2i (x_name.c:210)
==2690== by 0x788058: ASN1_item_ex_d2i (tasn_dec.c:239)
==2690== by 0x7890D4: asn1_template_noexp_d2i (tasn_dec.c:746)
==2690== by 0x788CB6: asn1_template_ex_d2i (tasn_dec.c:607)
==2690== by 0x78877A: ASN1_item_ex_d2i (tasn_dec.c:448)
==2690== by 0x7890D4: asn1_template_noexp_d2i (tasn_dec.c:746)
==2690== by 0x788CB6: asn1_template_ex_d2i (tasn_dec.c:607)
==2690== by 0x78877A: ASN1_item_ex_d2i (tasn_dec.c:448)
==2690== by 0x787C93: ASN1_item_d2i (tasn_dec.c:136)
==2690== by 0x78F5E4: d2i_X509 (x_x509.c:141)
==2690== by 0x7C9B91: PEM_ASN1_read_bio (pem_oth.c:81)
==2690== by 0x7CA506: PEM_read_bio_X509 (pem_x509.c:67)
==2690== by 0x703C9A: node::crypto::SecureContext::AddRootCerts(v8::Arguments const&) (node_crypto.cc:497)
==2690== Uninitialised value was created by a stack allocation
==2690== at 0x782E89: ASN1_STRING_to_UTF8 (a_strex.c:560)
2013-02-20 17:01:47 +04:00
da945a7376
openssl: make perlasm target pentium or newer for masm outputs
...
When perlasm generates MASM code it sets the assembler target to 468.
In this mode MASM refuses to assemble a couple of instructions. Bumping
the target to 686 solves this problem.
2013-02-20 17:00:29 +04:00
eb29c4b2e6
openssl: disable HT sidechannel attack mitigation
...
It used to be off before. It's extremely unlikely that such an attack
would be a viable attack against node. And it makes AES much slower.
2013-02-20 16:49:03 +04:00
f317f5aee9
openssl: update to 1.0.1e
2013-02-20 16:48:20 +04:00
4911a30803
npm: Upgrade to 1.2.12
2013-02-19 13:18:36 -08:00
d75e39794b
Merge remote-tracking branch 'ry/v0.8' into master
...
Conflicts:
AUTHORS
ChangeLog
lib/http.js
src/node_version.h
test/simple/test-http-header-response-splitting.js
2013-02-18 10:21:08 -08:00
73be4608d9
npm: Upgrade to v1.2.11
2013-02-15 10:49:30 -08:00
e4a856e0ba
V8: Reapply floating patches
2013-02-08 17:18:41 -08:00
0c2e5ec840
V8: Upgrade to 3.15.11.15
2013-02-08 17:17:45 -08:00
5cc3569f6d
Merge remote-tracking branch 'ry/v0.8' into master
...
Conflicts:
AUTHORS
ChangeLog
deps/npm/html/api/bin.html
deps/npm/html/api/bugs.html
deps/npm/html/api/commands.html
deps/npm/html/api/config.html
deps/npm/html/api/deprecate.html
deps/npm/html/api/docs.html
deps/npm/html/api/edit.html
deps/npm/html/api/explore.html
deps/npm/html/api/help-search.html
deps/npm/html/api/init.html
deps/npm/html/api/install.html
deps/npm/html/api/link.html
deps/npm/html/api/load.html
deps/npm/html/api/ls.html
deps/npm/html/api/npm.html
deps/npm/html/api/outdated.html
deps/npm/html/api/owner.html
deps/npm/html/api/pack.html
deps/npm/html/api/prefix.html
deps/npm/html/api/prune.html
deps/npm/html/api/publish.html
deps/npm/html/api/rebuild.html
deps/npm/html/api/restart.html
deps/npm/html/api/root.html
deps/npm/html/api/run-script.html
deps/npm/html/api/search.html
deps/npm/html/api/shrinkwrap.html
deps/npm/html/api/start.html
deps/npm/html/api/stop.html
deps/npm/html/api/submodule.html
deps/npm/html/api/tag.html
deps/npm/html/api/test.html
deps/npm/html/api/uninstall.html
deps/npm/html/api/unpublish.html
deps/npm/html/api/update.html
deps/npm/html/api/version.html
deps/npm/html/api/view.html
deps/npm/html/api/whoami.html
deps/npm/html/doc/README.html
deps/npm/html/doc/adduser.html
deps/npm/html/doc/bin.html
deps/npm/html/doc/bugs.html
deps/npm/html/doc/build.html
deps/npm/html/doc/bundle.html
deps/npm/html/doc/cache.html
deps/npm/html/doc/changelog.html
deps/npm/html/doc/coding-style.html
deps/npm/html/doc/completion.html
deps/npm/html/doc/config.html
deps/npm/html/doc/dedupe.html
deps/npm/html/doc/deprecate.html
deps/npm/html/doc/developers.html
deps/npm/html/doc/disputes.html
deps/npm/html/doc/docs.html
deps/npm/html/doc/edit.html
deps/npm/html/doc/explore.html
deps/npm/html/doc/faq.html
deps/npm/html/doc/folders.html
deps/npm/html/doc/global.html
deps/npm/html/doc/help-search.html
deps/npm/html/doc/help.html
deps/npm/html/doc/index.html
deps/npm/html/doc/init.html
deps/npm/html/doc/install.html
deps/npm/html/doc/json.html
deps/npm/html/doc/link.html
deps/npm/html/doc/ls.html
deps/npm/html/doc/npm.html
deps/npm/html/doc/outdated.html
deps/npm/html/doc/owner.html
deps/npm/html/doc/pack.html
deps/npm/html/doc/prefix.html
deps/npm/html/doc/prune.html
deps/npm/html/doc/publish.html
deps/npm/html/doc/rebuild.html
deps/npm/html/doc/registry.html
deps/npm/html/doc/removing-npm.html
deps/npm/html/doc/restart.html
deps/npm/html/doc/rm.html
deps/npm/html/doc/root.html
deps/npm/html/doc/run-script.html
deps/npm/html/doc/scripts.html
deps/npm/html/doc/search.html
deps/npm/html/doc/semver.html
deps/npm/html/doc/shrinkwrap.html
deps/npm/html/doc/star.html
deps/npm/html/doc/start.html
deps/npm/html/doc/stop.html
deps/npm/html/doc/submodule.html
deps/npm/html/doc/tag.html
deps/npm/html/doc/test.html
deps/npm/html/doc/uninstall.html
deps/npm/html/doc/unpublish.html
deps/npm/html/doc/update.html
deps/npm/html/doc/version.html
deps/npm/html/doc/view.html
deps/npm/html/doc/whoami.html
deps/npm/man/man1/global.1
deps/npm/man/man1/ls.1
deps/npm/man/man1/npm.1
deps/npm/man/man1/rm.1
deps/npm/man/man3/npm.3
deps/npm/node_modules/glob/glob.js
deps/npm/node_modules/glob/package.json
deps/npm/node_modules/node-gyp/package.json
deps/npm/node_modules/npm-registry-client/package.json
deps/npm/node_modules/npmconf/package.json
deps/npm/node_modules/read-installed/package.json
deps/npm/node_modules/rimraf/package.json
deps/npm/node_modules/rimraf/rimraf.js
deps/npm/package.json
deps/uv/src/win/error.c
doc/api/crypto.markdown
lib/zlib.js
src/node_version.h
src/node_zlib.cc
test/simple/test-buffer.js
2013-02-06 16:29:30 -08:00
5aef65a98a
npm: Upgrade to v1.2.10
2013-02-06 08:39:31 -08:00
202b5db4ef
v8: loosen artificial mmap constraint
...
Fixes #4010 .
2013-02-06 13:30:59 +04:00
1a87776be9
deps: upgrade libuv to 034ea31
2013-01-30 20:30:10 +01:00
e722ca32d9
npm: Upgrade to v1.2.3
2013-01-24 09:10:01 -08:00
7a2ebce8d8
V8: Reapply floating patches
2013-01-24 09:10:01 -08:00
8024252877
V8: Upgrade to 3.15.11.10
2013-01-24 09:10:01 -08:00
e2acf26a91
deps: upgrade libuv to e4d8cba
2013-01-23 00:17:01 +01:00
814bdf0f51
deps: upgrade libuv to 7841f77
2013-01-22 16:21:25 +01:00
4d32fc5964
npm: Upgrade to v1.2.2
2013-01-18 12:12:07 -08:00
0459a60232
npm: Upgrade to 1.2.2
2013-01-18 08:37:32 -08:00
8b0f3ce397
v8: add %p option to --logfile, expands to pid
...
Useful when you are profiling multiple instances of V8 concurrently.
Submitted upstream: http://code.google.com/p/v8/issues/detail?id=2503
Refs #4617 .
2013-01-18 01:33:12 +01:00
952e42de72
deps: upgrade libuv to 4ba03dd
2013-01-16 23:38:02 +01:00
9668df8b39
v8: work around String::WriteAscii segfault
...
See http://code.google.com/p/v8/issues/detail?id=2493 for details.
Once the patch lands in upstream V8, this commit can be reverted.
2013-01-15 23:46:30 +01:00
926c90bc64
v8: Hardfloat does not imply VFPv3, only VFPv2.
...
Raspberry Pi is an example.
BUG=v8:2393
Review URL: https://chromiumcodereview.appspot.com/11570061
Patch from Chi-Thanh Christopher Nguyen <nguyenchithanh@gmail.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@13232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This is a backport of v8/v8@44419ad089 .
2013-01-13 18:26:58 +01:00
e4f2a140d2
deps: upgrade libuv to 8e3e60f
2013-01-13 01:29:34 +01:00
8018113910
v8: remove optimization switches
...
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
we set them globally in $(TOPLEVEL)/common.gypi.
Commit 7b4d95a4b8629d
2013-01-12 00:34:36 +04:00
d22bd9e3c4
deps: update v8 to 3.15.11.7
2013-01-12 00:10:45 +04:00
97db62b4d9
Merge remote-tracking branch 'ry/v0.8' into master
...
Conflicts:
AUTHORS
ChangeLog
Makefile
src/node_version.h
2013-01-11 10:18:07 -08:00
31fc52ab53
deps: upgrade libuv to 9aab5d4
2013-01-11 14:00:19 +01:00
438e0c6d75
v8: Hardfloat does not imply VFPv3, only VFPv2.
...
Raspberry Pi is an example.
BUG=v8:2393
Review URL: https://chromiumcodereview.appspot.com/11570061
Patch from Chi-Thanh Christopher Nguyen <nguyenchithanh@gmail.com>.
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@13232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This is a backport of v8/v8@44419ad089 .
2013-01-10 17:02:59 -08:00
aa742ddf80
npm: Upgrade to v1.2.0
2013-01-09 15:21:30 -08:00
93591a2a88
v8: remove optimization switches
...
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
we set them globally in $(TOPLEVEL)/common.gypi.
Commit 7b4d95a4b8629d
2013-01-04 20:06:03 +04:00
0054264d88
v8: update to 3.15.11.5
2013-01-04 15:44:47 +04:00
ce1b33a9dc
v8: remove optimization switches
...
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi,
we set them globally in $(TOPLEVEL)/common.gypi.
Commit 7b4d95a4b8629d
2013-01-03 02:37:22 +01:00
7b4d95a976
deps: update v8 to 3.15.11
2013-01-01 16:07:02 +04:00
a7cc53067d
deps: upgrade libuv to 4997738
2012-12-29 17:34:41 +01:00
6ecb0cd65d
openssl: clean up openssl.gyp
...
Remove obsolete build configuration that escaped the purge in 7eaea7f
2012-12-24 16:02:13 +01:00
f119effc9f
Merge remote-tracking branch 'ry/v0.8'
2012-12-21 11:08:32 -08:00
d30e76e0e8
npm: upgrade to 1.1.70
2012-12-21 16:42:29 +00:00
7475982801
openssl: enable optimized asm code on x86 and x64
2012-12-20 15:02:59 +01:00
5edbb53c45
openssl: regenerate asm files for openssl 1.0.1
2012-12-20 15:02:59 +01:00
1b5c5b137d
openssl: update makefile for asm files to work with openssl 1.0.1
2012-12-20 15:02:58 +01:00
1d97db5acf
openssl: disable HT sidechannel attack mitigation
...
It used to be off before. It's extremely unlikely that such an attack
would be a viable attack against node. And it makes AES much slower.
2012-12-20 15:02:57 +01:00
aeae22cbb2
openssl: revert empty_OPENSSL_cpuid_setup.patch
2012-12-20 15:02:57 +01:00
2e6180a62a
openssl: make perlasm target pentium or newer for masm outputs
...
When perlasm generates MASM code it sets the assembler target to 468.
In this mode MASM refuses to assemble a couple of instructions. Bumping
the target to 686 solves this problem.
2012-12-20 15:02:56 +01:00
7eaea7f9e5
openssl: clean up and merge configuration files
...
This patch brings the openssl library that is built with gyp closer
to what the standard build system produces.
All opensslconf.h versions are now merged into a single file, which
makes it easier for compiled addons to locate this file.
2012-12-20 15:02:56 +01:00
7b2ef2de20
deps: upgrade libuv to dc559a5
2012-12-18 15:46:00 +01:00
ba754524a9
deps: upgrade libuv to b86ed94
2012-12-18 14:15:02 +04:00
77ed12fe7a
Merge remote-tracking branch 'ry/v0.8' into master
...
Conflicts:
AUTHORS
ChangeLog
deps/uv/test/test-spawn.c
deps/uv/uv.gyp
src/cares_wrap.cc
src/node.cc
src/node_version.h
test/simple/test-buffer.js
tools/gyp/pylib/gyp/common.py
tools/install.py
2012-12-13 16:57:58 -08:00
6cf68aead6
deps: upgrade libuv to e079a99
2012-12-13 20:23:01 +01:00
Ben Noordhuis
Bert Belder
Fedor Indutny
isaacs
Bryan Cantrill
yangguo@chromium.org