3 Commits (de8ef3f954622422ddb41775c06b278f0c8361a5)

Author	SHA1	Message	Date
Ben Noordhuis	9e9c83ea95	test: check that this != new.target in addon ... Add two checks that are there for expository reasons as much as they are sanity checks. PR-URL: https://github.com/nodejs/node/pull/15681 Refs: https://github.com/nodejs/node-addon-api/issues/142 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	2017-10-02 01:20:27 -03:00
Gabriel Schulhof	78286984da	test,doc: make module name match gyp target name ... Currently the nm_modname does not match the file name of the resulting module. In fact, the nm_modname is pretty arbitrary. This seeks to introduce some consistency into the nm_modname property by having the name of the module appear in exactly one place: the "target_name" property of the gyp target that builds the module. PR-URL: https://github.com/nodejs/node/pull/15209 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	2017-09-10 00:15:49 +03:00
Ben Noordhuis	13c4f44e97	test: add new.target add-on regression test ... Add a test that checks that new.target inheritance works when inheriting from a constructor defined in C++. PR-URL: https://github.com/nodejs/node/pull/9689 Refs: https://github.com/nodejs/node/issues/9288 Refs: https://github.com/nodejs/node/pull/9293 Reviewed-By: Anna Henningsen <anna@addaleax.net>	2016-11-21 14:34:25 +01:00